Lazily generate HistoryItem's serialized form state

Source/core/html/HTMLFormControlElementWithState.cpp

Index: Source/core/html/HTMLFormControlElementWithState.cpp
diff --git a/Source/core/html/HTMLFormControlElementWithState.cpp b/Source/core/html/HTMLFormControlElementWithState.cpp
index 4ecb0e9cf39b4079e98374b39f08002d3c0f7f65..23375e1dd90e7eead4a1ef73fca98dbffdf09b9e 100644
--- a/Source/core/html/HTMLFormControlElementWithState.cpp
+++ b/Source/core/html/HTMLFormControlElementWithState.cpp
@@ -29,6 +29,7 @@
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/forms/FormController.h"
+#include "core/loader/FrameLoaderClient.h"
 #include "core/page/Chrome.h"
 #include "core/page/ChromeClient.h"
 
@@ -70,13 +71,13 @@ void HTMLFormControlElementWithState::notifyFormStateChanged()
     // selection before the document is active (or even in a frame).
     if (!document().isActive())
         return;
-    document().frame()->loader().markDocumentStateDirty();
+    document().frame()->loader().client()->didUpdateCurrentHistoryItem();
 }
 
 bool HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState() const
 {
     // We don't save/restore control state in a form with autocomplete=off.
-    return inActiveDocument() && shouldAutocomplete();
+    return inDocument() && shouldAutocomplete();

[Nate Chapin, 2014/04/17 21:16:25]

Remove the active check because we might be generating the saved state as the
document going away. That check is 5+ years old and I can't find evidence it's
necessary.

[abarth-chromium, 2014/04/17 23:41:24]

Ok.

 }
 
 FormControlState HTMLFormControlElementWithState::saveFormControlState() const