Lazily generate HistoryItem's serialized form state

Source/core/html/HTMLFormControlElementWithState.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 11 matching lines @@
  *
  */
 
 #include "config.h"
 #include "core/html/HTMLFormControlElementWithState.h"
 
 #include "core/frame/FrameHost.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/forms/FormController.h"
+#include "core/loader/FrameLoaderClient.h"
 #include "core/page/Chrome.h"
 #include "core/page/ChromeClient.h"
 
 namespace WebCore {
 
 HTMLFormControlElementWithState::HTMLFormControlElementWithState(const QualifiedName& tagName, Document& doc, HTMLFormElement* f)
     : HTMLFormControlElement(tagName, doc, f)
 {
 }
 
@@ skipping 21 matching lines @@
         return true;
     return form()->shouldAutocomplete();
 }
 
 void HTMLFormControlElementWithState::notifyFormStateChanged()
 {
     // This can be called during fragment parsing as a result of option
     // selection before the document is active (or even in a frame).
     if (!document().isActive())
         return;
-    document().frame()->loader().markDocumentStateDirty();
+    document().frame()->loader().client()->didUpdateCurrentHistoryItem();
 }
 
 bool HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState() const
 {
     // We don't save/restore control state in a form with autocomplete=off.
-    return inActiveDocument() && shouldAutocomplete();
+    return inDocument() && shouldAutocomplete();

[Nate Chapin, 2014/04/17 21:16:25]

Remove the active check because we might be generating the saved state as the
document going away. That check is 5+ years old and I can't find evidence it's
necessary.

[abarth-chromium, 2014/04/17 23:41:24]

Ok.

 }
 
 FormControlState HTMLFormControlElementWithState::saveFormControlState() const
 {
     return FormControlState();
 }
 
 void HTMLFormControlElementWithState::finishParsingChildren()
 {
     HTMLFormControlElement::finishParsingChildren();
     document().formController().restoreControlStateFor(*this);
 }
 
 bool HTMLFormControlElementWithState::isFormControlElementWithState() const
 {
     return true;
 }
 
 } // namespace Webcore