Issue 239993006: Revert of Add flipped gradient branch to two point conical gradient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239993006: Revert of Add flipped gradient branch to two point conical gradient (Closed)

Created:
6 years, 8 months ago by egdaniel

Modified:
6 years, 8 months ago

Reviewers:
bsalomon, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Add flipped gradient branch to two point conical gradient (https://codereview.chromium.org/227623004/) Reason for revert: Breaking all CompareGMs Original issue's description: > Add flipped gradient branch to two point conical gradient > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14235 TBR=bsalomon@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14236

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -119 lines)			Patch
M	include/core/SkPicture.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	2 chunks	+3 lines, -46 lines	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.h	View	4 chunks	+6 lines, -10 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	9 chunks	+6 lines, -28 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp	View	10 chunks	+7 lines, -28 lines	0 comments	Download

Total messages: 3 (0 generated)

egdaniel

Created Revert of Add flipped gradient branch to two point conical gradient

6 years, 8 months ago (2014-04-17 13:56:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/239993006/1

6 years, 8 months ago (2014-04-17 13:57:11 UTC) #2

Message was sent while issue was closed.

Change committed as 14236