Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 2399603002: views: don't send OnKeypressUnhandled for all keys (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index 4642d23fc89a89633cc84ff72fbb5011959a7b9d..3eddb18f9b22e41073d740b8403cb3885c13f8d9 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -684,9 +684,6 @@ bool Textfield::OnKeyPressed(const ui::KeyEvent& event) {
ExecuteTextEditCommand(edit_command);
handled = true;
}
-
- if (!handled)
sky 2016/10/06 15:58:12 Should this instead check handled || event.handled
Elly Fong-Jones 2016/10/06 16:20:05 I don't think so - for example, when you tab away
- OnKeypressUnhandled();
return handled;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698