views: don't send OnKeypressUnhandled for all keys

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 #include <utility>
 
 #include "base/trace_event/trace_event.h"
@@ skipping 666 matching lines @@
   }
 #endif
 
   if (edit_command == ui::TextEditCommand::INVALID_COMMAND)
     edit_command = GetCommandForKeyEvent(event);
 
   if (!handled && IsTextEditCommandEnabled(edit_command)) {
     ExecuteTextEditCommand(edit_command);
     handled = true;
   }
-
-  if (!handled)

[sky, 2016/10/06 15:58:12]

Should this instead check handled || event.handled() ||
event.stopped_propagation()?

[Elly Fong-Jones, 2016/10/06 16:20:05]

I don't think so - for example, when you tab away from the textfield, the event
is handled further up the view hierarchy (as I understand it), so by the time
OnKeyPressed runs, the event hasn't been handled yet, but will be in future.

-    OnKeypressUnhandled();
   return handled;
 }
 
 bool Textfield::OnKeyReleased(const ui::KeyEvent& event) {
   return controller_ && controller_->HandleKeyEvent(this, event);
 }
 
 void Textfield::OnGestureEvent(ui::GestureEvent* event) {
   switch (event->type()) {
     case ui::ET_GESTURE_TAP_DOWN:
@@ skipping 1359 matching lines @@
 }
 
 void Textfield::OnCursorBlinkTimerFired() {
   DCHECK(ShouldBlinkCursor());
   gfx::RenderText* render_text = GetRenderText();
   render_text->set_cursor_visible(!render_text->cursor_visible());
   RepaintCursor();
 }
 
 }  // namespace views