Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2399423004: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, chromium-apps-reviews_chromium.org, kinuko+fileapi, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some ChromeSyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - permissions - screenlock_private - signed_in_devices - sync_file_system - tab_catpure - web_navigation BUG=634140 Committed: https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99 Cr-Commit-Position: refs/heads/master@{#424004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -130 lines) Patch
M chrome/browser/extensions/api/permissions/permissions_api.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 3 chunks +22 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 2 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 3 chunks +16 lines, -26 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 4 chunks +14 lines, -28 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
Antony, can you take a look?
4 years, 2 months ago (2016-10-07 21:28:25 UTC) #5
asargent_no_longer_on_chrome
lgtm
4 years, 2 months ago (2016-10-07 22:24:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399423004/1
4 years, 2 months ago (2016-10-07 23:09:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 23:14:53 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:18:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99
Cr-Commit-Position: refs/heads/master@{#424004}

Powered by Google App Engine
This is Rietveld 408576698