chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc - Issue 2399423004: [Extensions] Convert some ChromeSyncExtensionFunctions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

Issue 2399423004: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

index 4504d3c9240b589ec4bd5e939b579b3891d281ad..02e97473912c6358a4e20ed27c12cf80fc0741f8 100644

--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

@@ -96,7 +96,8 @@ ScreenlockPrivateAcceptAuthAttemptFunction::

ScreenlockPrivateAcceptAuthAttemptFunction::

~ScreenlockPrivateAcceptAuthAttemptFunction() {}

-bool ScreenlockPrivateAcceptAuthAttemptFunction::RunSync() {

+ExtensionFunction::ResponseAction

+ScreenlockPrivateAcceptAuthAttemptFunction::Run() {

std::unique_ptr<screenlock::AcceptAuthAttempt::Params> params(

screenlock::AcceptAuthAttempt::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

@@ -105,7 +106,7 @@ bool ScreenlockPrivateAcceptAuthAttemptFunction::RunSync() {

EasyUnlockService* service = EasyUnlockService::Get(profile);

if (service)

service->FinalizeUnlock(params->accept);

- return true;

+ return RespondNow(NoArguments());

}

ScreenlockPrivateEventRouter::ScreenlockPrivateEventRouter(