Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2399403005: Revert of Wait cloudtail termination in goma module (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Wait cloudtail termination in goma module (patchset #7 id:120001 of https://codereview.chromium.org/2386073002/ ) Reason for revert: https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/builds/1134/steps/stop%20cloudtail/logs/stdio Traceback (most recent call last): File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 111, in <module> sys.exit(main()) File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 108, in main wait_termination(int(f.read())) File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 69, in wait_termination os.waitpid(pid, 0) OSError: [Errno 10] No child processes step returned non-zero exit code: 1 Need to ignore OSError ECHILD? Original issue's description: > Wait cloudtail termination in goma module > > This is follow up CL for https://codereview.chromium.org/2375843005/ > > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/5ba4397bb3ab875a37501ec8eb0de33d1b4a1514 TBR=vadimsh@chromium.org,phajdan.jr@chromium.org,ukai@chromium.org,shinyak@chromium.org,yyanagisawa@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/b38036b7df8cb000c51784ccd898571e9371a4cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -54 lines) Patch
M scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py View 3 chunks +1 line, -54 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tikuta
Created Revert of Wait cloudtail termination in goma module
4 years, 2 months ago (2016-10-07 23:46:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399403005/1
4 years, 2 months ago (2016-10-07 23:47:02 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:47:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/b38036b7df8cb000c517...

Powered by Google App Engine
This is Rietveld 408576698