Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

Issue 2399403005: Revert of Wait cloudtail termination in goma module (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2016 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import errno 7 import errno
8 import os 8 import os
9 import signal 9 import signal
10 import subprocess 10 import subprocess
11 import sys 11 import sys
12 import time
13 12
14 from slave import goma_utils 13 from slave import goma_utils
15 14
16 15
17 def start_cloudtail(args): 16 def start_cloudtail(args):
18 """Write process id of started cloudtail to file object f""" 17 """Write process id of started cloudtail to file object f"""
19 18
20 proc = subprocess.Popen([args.cloudtail_path, 19 proc = subprocess.Popen([args.cloudtail_path,
21 'tail', 20 'tail',
22 '--log-id', 'goma_compiler_proxy', 21 '--log-id', 'goma_compiler_proxy',
23 '--path', 22 '--path',
24 goma_utils.GetLatestGomaCompilerProxyInfo()]) 23 goma_utils.GetLatestGomaCompilerProxyInfo()])
25 with open(args.pid_file, 'w') as f: 24 with open(args.pid_file, 'w') as f:
26 f.write(str(proc.pid)) 25 f.write(str(proc.pid))
27 26
28 def is_running_posix(pid):
29 """Return True if process of pid is running.
30
31 Args:
32 pid(int): pid of process which this function checks
33 whether it is running or not.
34
35 Returns:
36 bool: True if process of pid is running.
37
38 Raises:
39 OSError if something happens in os.kill(pid, 0)
40 """
41
42 try:
43 os.kill(pid, 0)
44 except OSError as e:
45 if e.errno == errno.ESRCH or e.errno == errno.EPERM:
46 return False
47 os.kill(pid, signal.SIGKILL)
48 print('killed process %d due to OSError %s' % (pid, e))
49 raise e
50 return True
51
52 def wait_termination(pid):
53 """Send SIGINT to pid and wait termination of pid.
54
55 Args:
56 pid(int): pid of process which this function waits termination.
57
58 Raises:
59 OSError: is_running_posix, os.waitpid and os.kill may throw OSError.
60 """
61
62 try:
63 os.kill(pid, signal.SIGINT)
64 except:
65 os.kill(pid, signal.SIGKILL)
66 raise
67
68 if os.name == 'nt':
69 os.waitpid(pid, 0)
70 else:
71 for _ in xrange(10):
72 if not is_running_posix(pid):
73 break
74 time.sleep(1)
75
76 if is_running_posix(pid):
77 os.kill(pid, signal.SIGKILL)
78 print('killed process %d running more than 10 seconds' % pid)
79
80 def main(): 27 def main():
81 parser = argparse.ArgumentParser( 28 parser = argparse.ArgumentParser(
82 description='cloudtail utility for goma recipe module.') 29 description='cloudtail utility for goma recipe module.')
83 30
84 subparsers = parser.add_subparsers(help='commands for cloudtail') 31 subparsers = parser.add_subparsers(help='commands for cloudtail')
85 32
86 parser_start = subparsers.add_parser('start', 33 parser_start = subparsers.add_parser('start',
87 help='subcommand to start cloudtail') 34 help='subcommand to start cloudtail')
88 parser_start.set_defaults(command='start') 35 parser_start.set_defaults(command='start')
89 parser_start.add_argument('--cloudtail-path', required=True, 36 parser_start.add_argument('--cloudtail-path', required=True,
90 help='path of cloudtail binary') 37 help='path of cloudtail binary')
91 parser_start.add_argument('--pid-file', required=True, 38 parser_start.add_argument('--pid-file', required=True,
92 help='file written pid') 39 help='file written pid')
93 40
94 parser_stop = subparsers.add_parser('stop', 41 parser_stop = subparsers.add_parser('stop',
95 help='subcommand to stop cloudtail') 42 help='subcommand to stop cloudtail')
96 parser_stop.set_defaults(command='stop') 43 parser_stop.set_defaults(command='stop')
97 parser_stop.add_argument('--killed-pid-file', required=True, 44 parser_stop.add_argument('--killed-pid-file', required=True,
98 help='file written the pid to be killed.') 45 help='file written the pid to be killed.')
99 46
100 args = parser.parse_args() 47 args = parser.parse_args()
101 48
102 if args.command == 'start': 49 if args.command == 'start':
103 start_cloudtail(args) 50 start_cloudtail(args)
104 elif args.command == 'stop': 51 elif args.command == 'stop':
105 with open(args.killed_pid_file) as f: 52 with open(args.killed_pid_file) as f:
106 # cloudtail flushes log and terminates 53 # cloudtail flushes log and terminates
107 # within 5 seconds when it recieves SIGINT. 54 # within 5 seconds when it recieves SIGINT.
108 wait_termination(int(f.read())) 55 os.kill(int(f.read()), signal.SIGINT)
109 56
110 if '__main__' == __name__: 57 if '__main__' == __name__:
111 sys.exit(main()) 58 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698