Issue 2399303002: Remove unused clobber option from compile.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2399303002: Remove unused clobber option from compile.py (Closed)

Created:
4 years, 2 months ago by tikuta

Modified:
4 years, 2 months ago

Reviewers:
ukai, Yoshisato Yanagisawa, shinyak

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

More Reviews

Description

Remove unused clobber option from compile.py I noticed that --clobber option is not used in chromium/api.py https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/api.py?rcl=0&l=159 BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	scripts/slave/compile.py	View		2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

shinyak

Any other places? I've searched a bit. I don't know this is being used somewhere, ...

4 years, 2 months ago (2016-10-07 05:43:57 UTC) #4

tikuta

4 years, 2 months ago (2016-10-07 06:34:40 UTC) #5

On 2016/10/07 05:43:57, shinyak wrote:
> Any other places?
> 
> I've searched a bit. I don't know this is being used somewhere, though.
>
https://cs.chromium.org/chromium/build/scripts/master/recipe_converter.py?q=c...

Ah, I'm not sure it is OK.
let me close this.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages