Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: scripts/slave/compile.py

Issue 2399303002: Remove unused clobber option from compile.py (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/compile.py
diff --git a/scripts/slave/compile.py b/scripts/slave/compile.py
index de55ec62eac6f49608fe6d2f0dca7ebeac6ec651..ccd73399e3c5723feac5f38b799407831e0986c0 100755
--- a/scripts/slave/compile.py
+++ b/scripts/slave/compile.py
@@ -406,16 +406,6 @@ def main_ninja(options, args, env):
print 'Updating environment.{x86,x64} files.'
UpdateWindowsEnvironment(options.target_output_dir, env)
- if options.clobber:
- print 'Removing %s' % options.target_output_dir
- # Deleting output_dir would also delete all the .ninja files necessary to
- # build. Clobbering should run before runhooks (which creates .ninja
- # files). For now, only delete all non-.ninja files.
- # TODO(thakis): Make "clobber" a step that runs before "runhooks".
- # Once the master has been restarted, remove all clobber handling
- # from compile.py, https://crbug.com/574557
- build_directory.RmtreeExceptNinjaOrGomaFiles(options.target_output_dir)
-
command.extend(options.build_args)
command.extend(args)
@@ -472,8 +462,6 @@ def get_target_build_dir(options):
def get_parsed_options():
option_parser = optparse.OptionParser()
- option_parser.add_option('--clobber', action='store_true', default=False,
- help='delete the output directory before compiling')
option_parser.add_option('--target', default='Release',
help='build target (Debug or Release)')
option_parser.add_option('--src-dir', default=None,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698