Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: Source/bindings/v8/ScriptController.cpp

Issue 23993004: Have convertNPVariantToV8Object() use the isolate it is given (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/V8NPObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptController.cpp
diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp
index f929daf07799895bab9558e1527783b0fe826291..db933b84f093573133af1412ac2c01af40e0b1cc 100644
--- a/Source/bindings/v8/ScriptController.cpp
+++ b/Source/bindings/v8/ScriptController.cpp
@@ -354,7 +354,7 @@ void ScriptController::bindToWindowObject(Frame* frame, const String& key, NPObj
v8::Context::Scope scope(v8Context);
- v8::Handle<v8::Object> value = createV8ObjectForNPObject(object, 0);
+ v8::Handle<v8::Object> value = createV8ObjectForNPObject(object, 0, m_isolate);
// Attach to the global object.
v8::Handle<v8::Object> global = v8Context->Global();
@@ -414,7 +414,7 @@ PassScriptInstance ScriptController::createScriptInstanceForWidget(Widget* widge
// NPObject as part of its wrapper. However, before accessing the object
// it must consult the _NPN_Registry.
- v8::Local<v8::Object> wrapper = createV8ObjectForNPObject(npObject, 0);
+ v8::Local<v8::Object> wrapper = createV8ObjectForNPObject(npObject, 0, m_isolate);
// Track the plugin object. We've been given a reference to the object.
m_pluginObjects.set(widget, npObject);
« no previous file with comments | « no previous file | Source/bindings/v8/V8NPObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698