Source/bindings/v8/V8NPObject.h - Issue 23993004: Have convertNPVariantToV8Object() use the isolate it is given

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8NPObject.h

Issue 23993004: Have convertNPVariantToV8Object() use the isolate it is given (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8NPObject.h

diff --git a/Source/bindings/v8/V8NPObject.h b/Source/bindings/v8/V8NPObject.h

index cd8d403dfda64a7cd16991af701765b2120a0150..4465b039868ac112cc19d43742df365d4c2f73a7 100644

--- a/Source/bindings/v8/V8NPObject.h

+++ b/Source/bindings/v8/V8NPObject.h

@@ -54,7 +54,7 @@ void npObjectInvokeDefaultHandler(const v8::FunctionCallbackInfo<v8::Value>&);

// Get a wrapper for a NPObject.

// If the object is already wrapped, the pre-existing wrapper will be returned. If the object is not wrapped, wrap it, and

// give V8 a weak reference to the wrapper which will cleanup when there are no more JS references to the object.

-v8::Local<v8::Object> createV8ObjectForNPObject(NPObject*, NPObject* root);

+v8::Local<v8::Object> createV8ObjectForNPObject(NPObject*, NPObject* root, v8::Isolate*);

// Tell V8 to forcibly remove an object.

// This is used at plugin teardown so that the caller can aggressively unload the plugin library. After calling this

« no previous file with comments | « Source/bindings/v8/ScriptController.cpp ('k') | Source/bindings/v8/V8NPObject.cpp » ('j') | no next file with comments »