Issue 23993004: Have convertNPVariantToV8Object() use the isolate it is given

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23993004: Have convertNPVariantToV8Object() use the isolate it is given (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken, marja

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have convertNPVariantToV8Object() use the isolate it is given convertNPVariantToV8Object() in V8NPUtils is given a v8::Isolate but fails to use it in several instances. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157520

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	Source/bindings/v8/ScriptController.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/V8NPObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8NPObject.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/bindings/v8/V8NPUtils.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23993004/1

7 years, 3 months ago (2013-09-10 14:04:55 UTC) #4

Message was sent while issue was closed.

Change committed as 157520

Expand Messages | Collapse Messages