Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2399243002: Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id… (Closed)

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id:160001 of https://codereview.chromium.org/2231523002/ ) Reason for revert: Reverting since it is causing flakiness on the blink bots. Latest flake: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7628 unexpected_failures: http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php TBR=japhet@chromium.org,alexmos@chromium.org,engedy@chromium.org,hiroshige@chromium.org BUG=616234 Committed: https://crrev.com/53cd7390c8d60e93fe3eb120e99677ad7754840b Cr-Commit-Position: refs/heads/master@{#423765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -104 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/resources/frame-loading-via-document-write.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/image-blocked-src-change.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/image-blocked-src-no-change.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/nonces/style-enforce-blocked.php View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/nonces/style-multiple-blocked.php View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-style-blocked.php View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/strict-dynamic/script-src-strict-dynamic.html View 7 chunks +17 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/strict-dynamic/script-src-strict-dynamic-whitelist.html View 1 chunk +6 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/style-blocked.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/local-image-from-remote.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-async-post-xhr-blocked-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image-expected.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 2 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399243002/1
4 years, 2 months ago (2016-10-06 22:49:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 00:43:56 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:46:09 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/53cd7390c8d60e93fe3eb120e99677ad7754840b
Cr-Commit-Position: refs/heads/master@{#423765}

Powered by Google App Engine
This is Rietveld 408576698