third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp - Issue 2399243002: Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

Issue 2399243002: Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id… (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

index c4ec3565360197f2ccb783301b391756888a02d7..bb8e94d4a7f9cc2f6707892c0b78243261990091 100644

--- a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

@@ -90,7 +90,7 @@ class WebDocumentSubresourceFilterTest : public ::testing::Test {

WebElement webElement = mainFrame()->document().querySelector("img");

ASSERT_TRUE(isHTMLImageElement(webElement));

HTMLImageElement* imageElement = toHTMLImageElement(webElement);

- EXPECT_EQ(loaded, !!imageElement->naturalWidth());

+ EXPECT_EQ(loaded, !!imageElement->cachedImage());

}

const std::string& baseURL() const { return m_baseURL; }