Linux Aura: Fix shadows on frameless windows

Linux Aura: Fix shadows on frameless windows

https://codereview.chromium.org/2153373002 fixed an issue with detecting Mesa
drivers on Linux.  Transparent visuals were only enabled on Mesa, so that CL
exposed an existing problem of opaque windows being rendered without drop
shadows.  This CL restores the previous behavior for 54 without reverting that
CL, and without having to pull in the large CLs that actually fixed this issue
on master.

NOTRY=true
NOPRESUBMIT=true

BUG=640170

[Tom (Use chromium acct), 2016-10-06 23:15:30]

Description was changed from

==========
Linux Aura: Fix shadows on frameless windows



NOTRY=true
NOPRESUBMIT=true

BUG=640170
==========

to

==========
Linux Aura: Fix shadows on frameless windows

https://codereview.chromium.org/2153373002 fixed an issue with detecting Mesa
drivers on Linux.  Transparent visuals were only enabled on Mesa, so that CL
exposed an existing problem of opaque windows being rendered without drop
shadows.  This CL restores the previous behavior for 54 without reverting that
CL, and without having to pull in the large CLs that actually fixed this issue
on master.

NOTRY=true
NOPRESUBMIT=true

BUG=640170
==========

[Tom (Use chromium acct), 2016-10-06 23:15:30]

thomasanderson@google.com changed reviewers:
+ clamy@chromium.org

[clamy, 2016-10-07 11:14:51]

Lgtm.

https://codereview.chromium.org/2399213003/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2399213003/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:759: if (!enable_transparent_visuals &&
nit: This is always true right?

[Tom (Use chromium acct), 2016-10-07 23:25:33]

https://codereview.chromium.org/2399213003/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2399213003/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:759: if (!enable_transparent_visuals &&
On 2016/10/07 11:14:51, clamy wrote:
> nit: This is always true right?

yes, done!

[Tom (Use chromium acct), 2016-10-07 23:25:42]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-07 23:25:43]

The patchset sent to the CQ was uploaded after l-g-t-m from clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2399213003/#ps20001
(title: "Remove always-true expression")

[commit-bot: I haz the power, 2016-10-07 23:26:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 23:29:25]

Description was changed from

==========
Linux Aura: Fix shadows on frameless windows

https://codereview.chromium.org/2153373002 fixed an issue with detecting Mesa
drivers on Linux.  Transparent visuals were only enabled on Mesa, so that CL
exposed an existing problem of opaque windows being rendered without drop
shadows.  This CL restores the previous behavior for 54 without reverting that
CL, and without having to pull in the large CLs that actually fixed this issue
on master.

NOTRY=true
NOPRESUBMIT=true

BUG=640170
==========

to

==========
Linux Aura: Fix shadows on frameless windows

https://codereview.chromium.org/2153373002 fixed an issue with detecting Mesa
drivers on Linux.  Transparent visuals were only enabled on Mesa, so that CL
exposed an existing problem of opaque windows being rendered without drop
shadows.  This CL restores the previous behavior for 54 without reverting that
CL, and without having to pull in the large CLs that actually fixed this issue
on master.

NOTRY=true
NOPRESUBMIT=true

BUG=640170
==========

[commit-bot: I haz the power, 2016-10-07 23:29:26]

Committed patchset #2 (id:20001)