Deflake the WebPopupFromExtension*HasValidOpener tests.

Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
TBR=rdevlin.cronin@chromium.org

Committed: https://crrev.com/906c43502ebae9b159a2c6353757b1fe83989b42
Cr-Commit-Position: refs/heads/master@{#423984}

[alexmos, 2016-10-06 21:02:17]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 21:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2016-10-06 21:05:20]

Description was changed from

==========
Deflake the WebPopupFromExtensionSubframeHasValidOpener test.

This CL removes two problematic checks which could have potentially
included the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next two lines already guarantee that the
popup ends up in the correct process.

BUG=653617
==========

to

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
==========

[alexmos, 2016-10-06 21:05:43]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[alexmos, 2016-10-06 21:05:54]

Description was changed from

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
==========

to

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
==========

[commit-bot: I haz the power, 2016-10-06 21:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2016-10-06 21:10:23]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org

[alexmos, 2016-10-06 21:10:23]

Charlie, can you please take a look at this quick followup to the
BrowsingInstance CL (https://codereview.chromium.org/2372323003), to fix
flakiness in the tests?  Seems like this problem has come up before in that test
class, and I could've also used NavigationCompletedObserver there, but in this
case I don't think these checks were actually buying us much given the existing
coverage, so I just removed them.

[Charlie Reis, 2016-10-06 21:32:29]

Thanks, LGTM.

[commit-bot: I haz the power, 2016-10-06 21:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:38:22]

Dry run: This issue passed the CQ dry run.

[alexmos, 2016-10-07 20:48:30]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-10-07 20:49:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 21:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:00:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alexmos, 2016-10-07 21:05:41]

Description was changed from

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
==========

to

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
TBR=rdevlin.cronin@chromium.org
==========

[alexmos, 2016-10-07 21:06:22]

TBRing Devlin for the trivial test change.

[alexmos, 2016-10-07 21:06:32]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:07:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:19:34]

Description was changed from

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
TBR=rdevlin.cronin@chromium.org
==========

to

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
TBR=rdevlin.cronin@chromium.org
==========

[commit-bot: I haz the power, 2016-10-07 22:19:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 22:23:04]

Description was changed from

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
TBR=rdevlin.cronin@chromium.org
==========

to

==========
Deflake the WebPopupFromExtension*HasValidOpener tests.

This CL removes two problematic checks which could have potentially
counted the original extension frame in the popup that was about to
be (but not yet) deleted.  These checks aren't essential to the test,
as the RPH checks on the next line already guarantee that the
popup ends up in the correct process.

BUG=653617
TBR=rdevlin.cronin@chromium.org

Committed: https://crrev.com/906c43502ebae9b159a2c6353757b1fe83989b42
Cr-Commit-Position: refs/heads/master@{#423984}
==========

[commit-bot: I haz the power, 2016-10-07 22:23:05]

Patchset 2 (id:??) landed as
https://crrev.com/906c43502ebae9b159a2c6353757b1fe83989b42
Cr-Commit-Position: refs/heads/master@{#423984}