Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3106)

Unified Diff: chrome/browser/extensions/process_manager_browsertest.cc

Issue 2399183003: Deflake the WebPopupFromExtension*HasValidOpener tests. (Closed)
Patch Set: More removal Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/process_manager_browsertest.cc
diff --git a/chrome/browser/extensions/process_manager_browsertest.cc b/chrome/browser/extensions/process_manager_browsertest.cc
index 0d430ebb8d08c4c00f3edab0cb8b2403bb666d68..620e8779287d4b74d0820bb886b279f39f69cd43 100644
--- a/chrome/browser/extensions/process_manager_browsertest.cc
+++ b/chrome/browser/extensions/process_manager_browsertest.cc
@@ -889,8 +889,6 @@ IN_PROC_BROWSER_TEST_F(ProcessManagerBrowserTest,
content::WebContents* popup = OpenPopup(main_frame, popup_url);
EXPECT_NE(popup, tab);
ASSERT_EQ(2, browser()->tab_strip_model()->count());
- EXPECT_EQ(1u, pm->GetRenderFrameHostsForExtension(extension->id()).size());
- EXPECT_EQ(1u, pm->GetAllFrames().size());
EXPECT_NE(popup->GetRenderProcessHost(), main_frame->GetProcess());
// Ensure the popup's window.opener is defined.
@@ -943,8 +941,6 @@ IN_PROC_BROWSER_TEST_F(ProcessManagerBrowserTest,
content::WebContents* popup = OpenPopup(extension_frame, popup_url);
EXPECT_NE(popup, tab);
ASSERT_EQ(2, browser()->tab_strip_model()->count());
- EXPECT_EQ(1u, pm->GetRenderFrameHostsForExtension(extension->id()).size());
- EXPECT_EQ(1u, pm->GetAllFrames().size());
EXPECT_NE(popup->GetRenderProcessHost(), extension_frame->GetProcess());
EXPECT_EQ(popup->GetRenderProcessHost(), main_frame->GetProcess());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698