[inspector] filter useless in preview internal properties

[inspector] filter useless in preview internal properties

Only subset of internal properties can be useful in preview, report only them.

BUG=chromium:653610
R=dgozman@chromium.org

Committed: https://crrev.com/fac3b6fa46b29142eafbb0060bcc4ffbe78c4cc4
Cr-Commit-Position: refs/heads/master@{#40064}

[kozy, 2016-10-06 23:28:52]

Dmitry, please take a look.

[dgozman, 2016-10-07 00:00:18]

lgtm

Let's run layout tests first though.

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
File src/inspector/v8-injected-script-host.cc (right):

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
src/inspector/v8-injected-script-host.cc:199: v8::Local<v8::Array> properties =
v8::Array::New(isolate);
Let's put this under throwJs.

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
src/inspector/v8-injected-script-host.cc:211: if (tryCatch.HasCaught()) return;
continue

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
src/inspector/v8-injected-script-host.cc:218: if (tryCatch.HasCaught()) return;
continue

https://codereview.chromium.org/2399003003/diff/60001/test/inspector/debugger...
File test/inspector/debugger/injected-script-internal-properties.js (right):

https://codereview.chromium.org/2399003003/diff/60001/test/inspector/debugger...
test/inspector/debugger/injected-script-internal-properties.js:5: print("Check
internal properties reported in object preview.");
object-preview.js

[kozy, 2016-10-07 00:20:31]

all done.

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
File src/inspector/v8-injected-script-host.cc (right):

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
src/inspector/v8-injected-script-host.cc:199: v8::Local<v8::Array> properties =
v8::Array::New(isolate);
On 2016/10/07 00:00:18, dgozman wrote:
> Let's put this under throwJs.

Done.

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
src/inspector/v8-injected-script-host.cc:211: if (tryCatch.HasCaught()) return;
On 2016/10/07 00:00:18, dgozman wrote:
> continue

Done.

https://codereview.chromium.org/2399003003/diff/60001/src/inspector/v8-inject...
src/inspector/v8-injected-script-host.cc:218: if (tryCatch.HasCaught()) return;
On 2016/10/07 00:00:18, dgozman wrote:
> continue

Done.

https://codereview.chromium.org/2399003003/diff/60001/test/inspector/debugger...
File test/inspector/debugger/injected-script-internal-properties.js (right):

https://codereview.chromium.org/2399003003/diff/60001/test/inspector/debugger...
test/inspector/debugger/injected-script-internal-properties.js:5: print("Check
internal properties reported in object preview.");
On 2016/10/07 00:00:18, dgozman wrote:
> object-preview.js

Done.

[kozy, 2016-10-07 00:20:36]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 00:20:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-10-07 00:25:13]

DevTools layout tests are passed successfully.

[kozy, 2016-10-07 00:25:18]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-10-07 00:25:21]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-07 00:25:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2399003003/#ps80001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-10-07 00:25:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 01:16:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-07 01:16:34]

Description was changed from

==========
[inspector] filter useless in preview internal properties

Only subset of internal properties can be useful in preview, report only them.

BUG=chromium:653610
R=dgozman@chromium.org
==========

to

==========
[inspector] filter useless in preview internal properties

Only subset of internal properties can be useful in preview, report only them.

BUG=chromium:653610
R=dgozman@chromium.org

Committed: https://crrev.com/fac3b6fa46b29142eafbb0060bcc4ffbe78c4cc4
Cr-Commit-Position: refs/heads/master@{#40064}
==========

[commit-bot: I haz the power, 2016-10-07 01:16:35]

Patchset 5 (id:??) landed as
https://crrev.com/fac3b6fa46b29142eafbb0060bcc4ffbe78c4cc4
Cr-Commit-Position: refs/heads/master@{#40064}