[inspector] filter useless in preview internal properties

src/inspector/v8-injected-script-host.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-injected-script-host.h"
 
 #include "src/base/macros.h"
 #include "src/inspector/injected-script-native.h"
 #include "src/inspector/string-util.h"
 #include "src/inspector/v8-debugger.h"
@@ skipping 148 matching lines @@
       unwrapInspector(info)->client()->valueSubtype(value);
   if (subtype) {
     info.GetReturnValue().Set(toV8String(isolate, subtype->string()));
     return;
   }
 }
 
 void V8InjectedScriptHost::getInternalPropertiesCallback(
     const v8::FunctionCallbackInfo<v8::Value>& info) {
   if (info.Length() < 1) return;
-  v8::Local<v8::Array> properties;
-  if (unwrapInspector(info)
-          ->debugger()
-          ->internalProperties(info.GetIsolate()->GetCurrentContext(), info[0])
-          .ToLocal(&properties))
-    info.GetReturnValue().Set(properties);
+
+  std::unordered_set<String16> allowedProperties;
+  if (info[0]->IsBooleanObject() || info[0]->IsNumberObject() ||
+      info[0]->IsStringObject() || info[0]->IsSymbolObject()) {
+    allowedProperties.insert(String16("[[PrimitiveValue]]"));
+  } else if (info[0]->IsPromise()) {
+    allowedProperties.insert(String16("[[PromiseStatus]]"));
+    allowedProperties.insert(String16("[[PromiseValue]]"));
+  } else if (info[0]->IsGeneratorObject()) {
+    allowedProperties.insert(String16("[[GeneratorStatus]]"));
+  } else if (info[0]->IsMapIterator() || info[0]->IsSetIterator()) {
+    allowedProperties.insert(String16("[[IteratorHasMore]]"));
+    allowedProperties.insert(String16("[[IteratorIndex]]"));
+    allowedProperties.insert(String16("[[IteratorKind]]"));
+    allowedProperties.insert(String16("[[Entries]]"));
+  } else if (info[0]->IsMap() || info[0]->IsWeakMap() || info[0]->IsSet() ||
+             info[0]->IsWeakSet()) {
+    allowedProperties.insert(String16("[[Entries]]"));
+  }
+  if (!allowedProperties.size()) return;
+
+  v8::Isolate* isolate = info.GetIsolate();
+  v8::Local<v8::Array> allProperties;
+  if (!unwrapInspector(info)
+           ->debugger()
+           ->internalProperties(isolate->GetCurrentContext(), info[0])
+           .ToLocal(&allProperties) ||
+      !allProperties->IsArray() || allProperties->Length() % 2 != 0)
+    return;
+
+  v8::Local<v8::Array> properties = v8::Array::New(isolate);

[dgozman, 2016/10/07 00:00:18]

Let's put this under throwJs.

[kozy, 2016/10/07 00:20:30]

Done.

+  {
+    v8::Local<v8::Context> context = isolate->GetCurrentContext();
+    v8::TryCatch tryCatch(isolate);
+    v8::Isolate::DisallowJavascriptExecutionScope throwJs(
+        isolate,
+        v8::Isolate::DisallowJavascriptExecutionScope::THROW_ON_FAILURE);
+
+    uint32_t outputIndex = 0;
+    for (uint32_t i = 0; i < allProperties->Length(); i += 2) {
+      v8::Local<v8::Value> key;
+      if (!allProperties->Get(context, i).ToLocal(&key)) continue;
+      if (tryCatch.HasCaught()) return;

[dgozman, 2016/10/07 00:00:18]

continue

[kozy, 2016/10/07 00:20:30]

Done.

+      String16 keyString = toProtocolStringWithTypeCheck(key);
+      if (keyString.isEmpty() ||
+          allowedProperties.find(keyString) == allowedProperties.end())
+        continue;
+      v8::Local<v8::Value> value;
+      if (!allProperties->Get(context, i + 1).ToLocal(&value)) continue;
+      if (tryCatch.HasCaught()) return;

[dgozman, 2016/10/07 00:00:18]

continue

[kozy, 2016/10/07 00:20:30]

Done.

+      createDataProperty(context, properties, outputIndex++, key);
+      createDataProperty(context, properties, outputIndex++, value);
+    }
+  }
+  info.GetReturnValue().Set(properties);
 }
 
 void V8InjectedScriptHost::objectHasOwnPropertyCallback(
     const v8::FunctionCallbackInfo<v8::Value>& info) {
   if (info.Length() < 2 || !info[0]->IsObject() || !info[1]->IsString()) return;
   bool result = info[0]
                     .As<v8::Object>()
                     ->HasOwnProperty(info.GetIsolate()->GetCurrentContext(),
                                      v8::Local<v8::String>::Cast(info[1]))
                     .FromMaybe(false);
@@ skipping 22 matching lines @@
     UNREACHABLE();
     return;
   }
   v8::Local<v8::Object> target = info[0].As<v8::Proxy>();
   while (target->IsProxy())
     target = v8::Local<v8::Proxy>::Cast(target)->GetTarget();
   info.GetReturnValue().Set(target);
 }
 
 }  // namespace v8_inspector