Chromium Code Reviews

Issue 2399003002: Revert of [heap] Concurrent slot filtering in sweeper threads. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Concurrent slot filtering in sweeper threads. (patchset #4 id:60001 of https://codereview.chromium.org/2401563002/ ) Reason for revert: Crashing. Original issue's description: > [heap] Concurrent slot filtering in sweeper threads. > > This is an intermediate step for concurrent slot filtering. This CL already makes filtering concurrent, but does not integrate it in the actual sweeping. This will be done in two follow up CLs. One for the regular slot set and one for the typed slot set. > > BUG=chromium:648568 > > Committed: https://crrev.com/1f89d369fc952a2826f9f62901fb84fcf30920d7 > Cr-Commit-Position: refs/heads/master@{#40040} TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Committed: https://crrev.com/0083c0931a1def528aca12b29133dd26c718fe28 Cr-Commit-Position: refs/heads/master@{#40043}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+100 lines, -46 lines)
M src/heap/mark-compact.h View 1 chunk +1 line, -0 lines 0 comments
M src/heap/mark-compact.cc View 3 chunks +24 lines, -5 lines 0 comments
M src/heap/remembered-set.h View 1 chunk +0 lines, -3 lines 0 comments
M src/heap/remembered-set.cc View 1 chunk +72 lines, -34 lines 0 comments
M src/heap/slot-set.h View 3 chunks +3 lines, -4 lines 0 comments

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Concurrent slot filtering in sweeper threads.
4 years, 2 months ago (2016-10-06 14:20:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399003002/1
4 years, 2 months ago (2016-10-06 14:20:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 14:20:50 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 14:21:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0083c0931a1def528aca12b29133dd26c718fe28
Cr-Commit-Position: refs/heads/master@{#40043}

Powered by Google App Engine