Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2398993003: MIPS[64]: Implement Word[32|64]ReverseByte instruction selector unit tests (Closed)

Created:
4 years, 2 months ago by predrag.rudic
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Implement Word[32|64]ReverseByte instruction selector unit tests BUG= Review-Url: https://codereview.chromium.org/2398993003 Cr-Commit-Position: refs/heads/master@{#42358} Committed: https://chromium.googlesource.com/v8/v8/+/0d0d623b5799daffd9825fee887d78ce29496471

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/compiler/raw-machine-assembler.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
predrag.rudic
PTAL
4 years, 2 months ago (2016-10-06 14:04:29 UTC) #2
ivica.bogosavljevic
lgtm, but you need approval from the file owner in order to land the patch. ...
4 years, 2 months ago (2016-10-06 14:12:27 UTC) #7
ivica.bogosavljevic
Reminder...
4 years, 2 months ago (2016-10-12 14:58:59 UTC) #8
titzer
On 2016/10/12 14:58:59, ivica.bogosavljevic wrote: > Reminder... lgtm, sorry for the delay.
3 years, 11 months ago (2017-01-10 09:58:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398993003/20001
3 years, 11 months ago (2017-01-16 10:29:54 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 10:32:30 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0d0d623b5799daffd9825fee887d78ce294...

Powered by Google App Engine
This is Rietveld 408576698