Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2398923002: Prune a new call site of createVisibleSelectionDeprecated from DragController (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune a new call site of createVisibleSelectionDeprecated from DragController This patch prunes a new call site of createVisibleSelectionDeprecated, which was introduced by r422915 and hence not catched by r423036, from DragController. BUG=651373 Committed: https://crrev.com/c974b72c00883f18763d11369b8a97696824e3f4 Cr-Commit-Position: refs/heads/master@{#423438}

Patch Set 1 #

Patch Set 2 : 201610061158 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/page/DragController.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-06 03:48:48 UTC) #9
tkent
lgtm
4 years, 2 months ago (2016-10-06 04:03:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398923002/20001
4 years, 2 months ago (2016-10-06 04:59:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 05:16:55 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 05:18:51 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c974b72c00883f18763d11369b8a97696824e3f4
Cr-Commit-Position: refs/heads/master@{#423438}

Powered by Google App Engine
This is Rietveld 408576698