Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 2398923002: Prune a new call site of createVisibleSelectionDeprecated from DragController (Closed)
Patch Set: 201610061158 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/DragController.cpp
diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp
index bab8bb4bd4520361d0fbc9a37f754990739778d6..deef70821c46a23988416cc6f90bec57a72dc81b 100644
--- a/third_party/WebKit/Source/core/page/DragController.cpp
+++ b/third_party/WebKit/Source/core/page/DragController.cpp
@@ -589,8 +589,12 @@ bool DragController::concludeEditDrag(DragData* dragData) {
dragCaret.base()))
return false;
- innerFrame->selection().setSelection(createVisibleSelectionDeprecated(
- range->startPosition(), range->endPosition()));
+ // TODO(xiaochengh): Use of updateStyleAndLayoutIgnorePendingStylesheets
+ // needs to be audited. See http://crbug.com/590369 for more details.
+ innerFrame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
+ innerFrame->selection().setSelection(
+ createVisibleSelection(range->startPosition(), range->endPosition()));
if (innerFrame->selection().isAvailable()) {
DCHECK(m_documentUnderMouse);
if (!innerFrame->editor().replaceSelectionAfterDraggingWithEvents(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698