Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2398903002: [Findit] Display confidence score on result page. (Closed)

Created:
4 years, 2 months ago by chanli
Modified:
4 years, 2 months ago
Reviewers:
stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Display confidence score on result page. BUG=653359 Committed: https://chromium.googlesource.com/infra/infra/+/91941e6a14c5c17ff7da1a39c5c2e7355acff51e

Patch Set 1 #

Total comments: 11

Patch Set 2 : address comments. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -16 lines) Patch
M appengine/findit/handlers/build_failure.py View 1 2 4 chunks +44 lines, -0 lines 0 comments Download
M appengine/findit/handlers/test/build_failure_test.py View 1 9 chunks +154 lines, -10 lines 0 comments Download
M appengine/findit/model/suspected_cl_confidence.py View 1 2 chunks +2 lines, -5 lines 0 comments Download
A appengine/findit/model/test/suspected_cl_confidence_test.py View 1 1 chunk +59 lines, -0 lines 0 comments Download
M appengine/findit/templates/build_failure.html View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
chanli
ptal.
4 years, 2 months ago (2016-10-06 01:51:52 UTC) #2
stgao
lgtm with nits. https://codereview.chromium.org/2398903002/diff/1/appengine/findit/handlers/build_failure.py File appengine/findit/handlers/build_failure.py (right): https://codereview.chromium.org/2398903002/diff/1/appengine/findit/handlers/build_failure.py#newcode20 appengine/findit/handlers/build_failure.py:20: from model.cl_confidence import CLConfidence Maybe SuspectConfidence ...
4 years, 2 months ago (2016-10-06 02:17:38 UTC) #3
lijeffrey
https://codereview.chromium.org/2398903002/diff/1/appengine/findit/handlers/build_failure.py File appengine/findit/handlers/build_failure.py (right): https://codereview.chromium.org/2398903002/diff/1/appengine/findit/handlers/build_failure.py#newcode335 appengine/findit/handlers/build_failure.py:335: confidences = CLConfidence.query().order(-CLConfidence.end_date).fetch(1) On 2016/10/06 02:17:38, stgao (slow) wrote: ...
4 years, 2 months ago (2016-10-06 14:10:33 UTC) #4
chanli
https://codereview.chromium.org/2398903002/diff/1/appengine/findit/handlers/build_failure.py File appengine/findit/handlers/build_failure.py (right): https://codereview.chromium.org/2398903002/diff/1/appengine/findit/handlers/build_failure.py#newcode20 appengine/findit/handlers/build_failure.py:20: from model.cl_confidence import CLConfidence On 2016/10/06 02:17:38, stgao (slow) ...
4 years, 2 months ago (2016-10-08 00:41:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398903002/20001
4 years, 2 months ago (2016-10-08 00:42:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398903002/40001
4 years, 2 months ago (2016-10-08 00:48:49 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 01:03:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/91941e6a14c5c17ff7da1a39c5c2e...

Powered by Google App Engine
This is Rietveld 408576698