[Findit] Display confidence score on result page.

appengine/findit/handlers/build_failure.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import copy
 from datetime import datetime
 
 from google.appengine.api import users
 
 from common import constants
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
 from common.waterfall import failure_type
 from handlers import handlers_util
 from handlers import result_status
 from handlers.result_status import NO_TRY_JOB_REASON_MAP
+from model import analysis_approach_type
 from model import analysis_status
-from model import cl_confidence
+from model.cl_confidence import CLConfidence

[stgao, 2016/10/06 02:17:38]

Maybe SuspectConfidence instead?

[chanli, 2016/10/08 00:41:10]

Done.

 from model import result_status as analysis_result_status
 from model import suspected_cl_status
 from model.base_build_model import BaseBuildModel
 from model.result_status import RESULT_STATUS_TO_DESCRIPTION
 from model.suspected_cl_status import CL_STATUS_TO_DESCRIPTION
 from model.wf_analysis import WfAnalysis
 from model.wf_suspected_cl import WfSuspectedCL
 from model.wf_try_job import WfTryJob
 from waterfall import build_failure_analysis_pipelines
 from waterfall import buildbot
@@ skipping 293 matching lines @@
     compile_failure = None
     for failure in analysis.result.get('failures', []):
       if failure['step_name'] == constants.COMPILE_STEP_NAME:
         compile_failure = failure
     if compile_failure:  # pragma: no branch.
       data['first_failure'] = compile_failure['first_failure']
       data['last_pass'] = compile_failure['last_pass']
       data['suspected_cls_by_heuristic'] = compile_failure['suspected_cls']
 
 
+def _GetMostRecentConfidence():  # pragma: no cover.
+  confidences = CLConfidence.query().order(-CLConfidence.end_date).fetch(1)

[stgao, 2016/10/06 02:17:38]

As I mentioned in the other CL, making CLConfidence versioned will make this
easier and faster with cache.

[lijeffrey, 2016/10/06 14:10:33]

+1

if we make CLConfidence versioned then this could be done in 1 line

[chanli, 2016/10/08 00:41:10]

Done.

+
+  return confidences[0] if confidences else None
+
+
+def _PercentFormat(float_number):
+  if not float_number or not isinstance(float_number, float):
+    return None
+  return '%.2f%%' % (float_number * 100)

[stgao, 2016/10/06 02:17:38]

I guess 70% is better than 70.87%.

[chanli, 2016/10/08 00:41:10]

Done.

+
+
+def _GetConfidence(confidence, cl_build):

[lijeffrey, 2016/10/06 14:10:33]

nit: rename this _GetConfidencePercentage or _GetConfidenceScore or something
more accurate, since GetConfidence sounds like it returns a confidence entity

[chanli, 2016/10/08 00:41:10]

Done.

+
+  if not confidence:
+    return None
+
+  if cl_build['failure_type'] == failure_type.COMPILE:
+    if cl_build['approaches'] == [
+        analysis_approach_type.HEURISTIC, analysis_approach_type.TRY_JOB]:
+      return _PercentFormat(confidence.compile_heuristic_try_job['confidence'])
+    elif cl_build['approaches'] == [analysis_approach_type.TRY_JOB]:
+      return _PercentFormat(confidence.compile_try_job['confidence'])
+    elif (cl_build['approaches'] == [analysis_approach_type.HEURISTIC] and
+          cl_build['top_score']):
+      return _PercentFormat(
+          confidence.compile_heuristic.get(
+              str(cl_build['top_score']), {}).get('confidence'))
+    else:
+      return None
+  else:
+    if cl_build['approaches'] == [
+        analysis_approach_type.HEURISTIC, analysis_approach_type.TRY_JOB]:
+      return _PercentFormat(confidence.test_heuristic_try_job['confidence'])
+    elif cl_build['approaches'] == [analysis_approach_type.TRY_JOB]:
+      return _PercentFormat(confidence.test_try_job['confidence'])
+    elif (cl_build['approaches'] == [analysis_approach_type.HEURISTIC] and
+          cl_build['top_score']):
+      return _PercentFormat(confidence.test_heuristic.get(
+          str(cl_build['top_score']), {}).get('confidence'))
+    else:  # pragma: no cover.

[lijeffrey, 2016/10/06 14:10:33]

why is this one no cover whereas the compile one does have it?

[chanli, 2016/10/08 00:41:10]

Done.

+      return None
+
+
 def _GetAllSuspectedCLsAndCheckStatus(
     master_name, builder_name, build_number, analysis):
   build_key = BaseBuildModel.CreateBuildId(
       master_name, builder_name, build_number)
   suspected_cls = copy.deepcopy(analysis.suspected_cls)
   if not suspected_cls:
     return []
 
+  cl_confidences = _GetMostRecentConfidence()
+
   for cl in suspected_cls:
     cl['status'] = _ANALYSIS_CL_STATUS_MAP.get(analysis.result_status, None)
+    cl['confidence'] = None
+
     suspected_cl = WfSuspectedCL.Get(cl['repo_name'], cl['revision'])
     if not suspected_cl:
       continue
 
     build = suspected_cl.builds.get(build_key)
     if build:
       cl['status'] = build['status']
+      cl['confidence'] = _GetConfidence(cl_confidences, build)
 
   return suspected_cls
 
 
 class BuildFailure(BaseHandler):
   PERMISSION_LEVEL = Permission.ANYONE
 
   def _ShowDebugInfo(self):
     # Show debug info only if the app is run locally during development, if the
     # currently logged-in user is an admin, or if it is explicitly requested
@@ skipping 101 matching lines @@
     else:
       self._PrepareDataForTestFailures(
         analysis, build_info, data, self._ShowDebugInfo())
       return {
         'template': 'waterfall/test_failure.html',
         'data': data
       }
 
   def HandlePost(self):  # pragma: no cover
     return self.HandleGet()