Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2398823002: Remove the "chromium" port name and --chromium platform option. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the "chromium" port name and --chromium platform option. Committed: https://crrev.com/fc8412e6867dfec328a5ade0b82204abeee76c84 Cr-Commit-Position: refs/heads/master@{#423677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
qyearsley
4 years, 2 months ago (2016-10-05 23:04:58 UTC) #3
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-06 17:49:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398823002/1
4 years, 2 months ago (2016-10-06 20:19:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 21:06:56 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:08:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc8412e6867dfec328a5ade0b82204abeee76c84
Cr-Commit-Position: refs/heads/master@{#423677}

Powered by Google App Engine
This is Rietveld 408576698