Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 2398823002: Remove the "chromium" port name and --chromium platform option. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2012 Google Inc. All rights reserved. 1 # Copyright (C) 2012 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 PORT_HAS_AUDIO_CODECS_BUILT_IN = True 422 PORT_HAS_AUDIO_CODECS_BUILT_IN = True
423 423
424 BUILD_REQUIREMENTS_URL = 'https://www.chromium.org/developers/how-tos/androi d-build-instructions' 424 BUILD_REQUIREMENTS_URL = 'https://www.chromium.org/developers/how-tos/androi d-build-instructions'
425 425
426 def __init__(self, host, port_name, **kwargs): 426 def __init__(self, host, port_name, **kwargs):
427 super(AndroidPort, self).__init__(host, port_name, **kwargs) 427 super(AndroidPort, self).__init__(host, port_name, **kwargs)
428 428
429 self._operating_system = 'android' 429 self._operating_system = 'android'
430 self._version = 'icecreamsandwich' 430 self._version = 'icecreamsandwich'
431 431
432 self._host_port = factory.PortFactory(host).get('chromium', **kwargs) 432 self._host_port = factory.PortFactory(host).get(**kwargs)
433 self._server_process_constructor = self._android_server_process_construc tor 433 self._server_process_constructor = self._android_server_process_construc tor
434 434
435 if not self.get_option('disable_breakpad'): 435 if not self.get_option('disable_breakpad'):
436 self._dump_reader = DumpReaderAndroid(host, self._build_path()) 436 self._dump_reader = DumpReaderAndroid(host, self._build_path())
437 437
438 if self.driver_name() != self.CONTENT_SHELL_NAME: 438 if self.driver_name() != self.CONTENT_SHELL_NAME:
439 raise AssertionError('Layout tests on Android only support content_s hell as the driver.') 439 raise AssertionError('Layout tests on Android only support content_s hell as the driver.')
440 440
441 self._driver_details = ContentShellDriverDetails() 441 self._driver_details = ContentShellDriverDetails()
442 442
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
1325 return command 1325 return command
1326 1326
1327 def _read_prompt(self, deadline): 1327 def _read_prompt(self, deadline):
1328 last_char = '' 1328 last_char = ''
1329 while True: 1329 while True:
1330 current_char = self._server_process.read_stdout(deadline, 1) 1330 current_char = self._server_process.read_stdout(deadline, 1)
1331 if current_char == ' ': 1331 if current_char == ' ':
1332 if last_char in ('#', '$'): 1332 if last_char in ('#', '$'):
1333 return 1333 return
1334 last_char = current_char 1334 last_char = current_char
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698