Disable Ctrl+Shift+P on Chrome OS

Disable Ctrl+Shift+P on Chrome OS

Chrome OS uses ENABLE_BASIC_PRINTING but has no system dialog.  Disable
the shortcut as invoking printing in this state causes a crash.

BUG=652220
TEST=Verify printing still works.  Ctrl+Shift+P is a nop.
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2376193006
Cr-Commit-Position: refs/heads/master@{#423047}
(cherry picked from commit 03b6108c27abe7ebecec0179c34c05938ae3e905)

[skau, 2016-10-05 18:42:00]

skau@chromium.org changed reviewers:
+ thestig@chromium.org

[skau, 2016-10-05 18:42:01]

Cherry-pick into M54.  I'm not a committer so I need approval.

[Lei Zhang, 2016-10-05 18:44:41]

lgtm

[skau, 2016-10-05 19:29:42]

The CQ bit was checked by skau@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:30:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 19:35:40]

Committed patchset #1 (id:1)

[boliu, 2016-10-05 23:45:25]

This breaks the build on the branch:

FAILED: build.ninja 
/android/release/src/buildtools/linux64/gn --root=/android/release/src -q gen
//out/Default/
ERROR at //chrome/common/features.gni:37:31: Undefined identifier
  enable_basic_print_dialog = enable_basic_printing && !is_chromeos
                              ^--------------------
See //chrome/android/chrome_public_apk_tmpl.gni:7:1: whence it was imported.
import("//chrome/common/features.gni")
^------------------------------------
See //chrome/android/BUILD.gn:8:1: whence it was imported.
import("//chrome/android/chrome_public_apk_tmpl.gni")
^---------------------------------------------------
See //BUILD.gn:413:9: which caused the file to be included.
        "//chrome/android:chrome_junit_tests",
        ^------------------------------------
ninja: error: rebuilding 'build.ninja': subcommand failed

[skau, 2016-10-05 23:52:00]

On 2016/10/05 23:45:25, boliu wrote:
> This breaks the build on the branch:
> 
> FAILED: build.ninja 
> /android/release/src/buildtools/linux64/gn --root=/android/release/src -q gen
> //out/Default/
> ERROR at //chrome/common/features.gni:37:31: Undefined identifier
>   enable_basic_print_dialog = enable_basic_printing && !is_chromeos
>                               ^--------------------
> See //chrome/android/chrome_public_apk_tmpl.gni:7:1: whence it was imported.
> import("//chrome/common/features.gni")
> ^------------------------------------
> See //chrome/android/BUILD.gn:8:1: whence it was imported.
> import("//chrome/android/chrome_public_apk_tmpl.gni")
> ^---------------------------------------------------
> See //BUILD.gn:413:9: which caused the file to be included.
>         "//chrome/android:chrome_junit_tests",
>         ^------------------------------------
> ninja: error: rebuilding 'build.ninja': subcommand failed

Fixed with https://codereview.chromium.org/2393283002.  Small issue with the
merge.

[boliu, 2016-10-05 23:57:15]

On 2016/10/05 23:52:00, skau wrote:
> On 2016/10/05 23:45:25, boliu wrote:
> > This breaks the build on the branch:
> > 
> > FAILED: build.ninja 
> > /android/release/src/buildtools/linux64/gn --root=/android/release/src -q
gen
> > //out/Default/
> > ERROR at //chrome/common/features.gni:37:31: Undefined identifier
> >   enable_basic_print_dialog = enable_basic_printing && !is_chromeos
> >                               ^--------------------
> > See //chrome/android/chrome_public_apk_tmpl.gni:7:1: whence it was imported.
> > import("//chrome/common/features.gni")
> > ^------------------------------------
> > See //chrome/android/BUILD.gn:8:1: whence it was imported.
> > import("//chrome/android/chrome_public_apk_tmpl.gni")
> > ^---------------------------------------------------
> > See //BUILD.gn:413:9: which caused the file to be included.
> >         "//chrome/android:chrome_junit_tests",
> >         ^------------------------------------
> > ninja: error: rebuilding 'build.ninja': subcommand failed
> 
> Fixed with https://codereview.chromium.org/2393283002.  Small issue with the
> merge.

Ahh, my sync just missed it