Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2393283002: Add missing import to chrome/common/features.gni (Closed)

Created:
4 years, 2 months ago by skau
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, josafat, josafat1
CC:
chromium-reviews, mummareddy_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Add missing import to chrome/common/features.gni import statment is missing in branch 2840 and required by cherry-picked change https://chromium.googlesource.com/chromium/src/+/5b0d241ad472b161b02867784e52fcad7c5e97f8 BUG=653250 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/common/features.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
skau
Please see commit message for details. This change is already on ToT.
4 years, 2 months ago (2016-10-05 21:17:33 UTC) #7
josafat
On 2016/10/05 21:17:33, skau wrote: > Please see commit message for details. This change is ...
4 years, 2 months ago (2016-10-05 23:22:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393283002/1
4 years, 2 months ago (2016-10-05 23:24:12 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-05 23:24:13 UTC) #12
skau
4 years, 2 months ago (2016-10-05 23:31:00 UTC) #14
skau
This is fixing a build failure so the bug doesn't have merge approval. The TPM ...
4 years, 2 months ago (2016-10-05 23:31:41 UTC) #15
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-05 23:33:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393283002/1
4 years, 2 months ago (2016-10-05 23:36:05 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:39:25 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698