|
|
Chromium Code Reviews
DescriptionAdd missing import to chrome/common/features.gni
import statment is missing in branch 2840 and required by cherry-picked
change
https://chromium.googlesource.com/chromium/src/+/5b0d241ad472b161b02867784e52fcad7c5e97f8
BUG=653250
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by skau@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Add missing import to chrome/common/features.gni import statment is missing in branch 2840 and required by cherry-picked change https://chromium.googlesource.com/chromium/src/+/5b0d241ad472b161b02867784e52... BUG=653250 ========== to ========== Add missing import to chrome/common/features.gni import statment is missing in branch 2840 and required by cherry-picked change https://chromium.googlesource.com/chromium/src/+/5b0d241ad472b161b02867784e52... BUG=653250 NOTRY=true NOPRESUBMIT=true ==========
skau@chromium.org changed reviewers: + josafat@chromium.org
Please see commit message for details. This change is already on ToT.
On 2016/10/05 21:17:33, skau wrote: > Please see commit message for details. This change is already on ToT. lgtm
The CQ bit was checked by skau@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
skau@chromium.org changed reviewers: + thestig@chromium.org
This is fixing a build failure so the bug doesn't have merge approval. The TPM has approved.
lgtm
The CQ bit was checked by skau@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add missing import to chrome/common/features.gni import statment is missing in branch 2840 and required by cherry-picked change https://chromium.googlesource.com/chromium/src/+/5b0d241ad472b161b02867784e52... BUG=653250 NOTRY=true NOPRESUBMIT=true ========== to ========== Add missing import to chrome/common/features.gni import statment is missing in branch 2840 and required by cherry-picked change https://chromium.googlesource.com/chromium/src/+/5b0d241ad472b161b02867784e52... BUG=653250 NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
