Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Issue 2398733005: Reland of Cache SubResourceIntegrity checks at Resource (patchset #2 id:20001 of https://codereview… (Closed)

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, Yoav Weiss, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Cache SubResourceIntegrity checks at Resource (patchset #2 id:20001 of https://codereview… (patchset #1 id:1 of https://codereview.chromium.org/2400723005/ ) Reason for revert: Reverting the revert, as the test continues failing. Original issue's description: > Revert of Cache SubResourceIntegrity checks at Resource (patchset #2 id:20001 of https://codereview.chromium.org/2398733003/ ) > > Reason for revert: > Reverting due to failing PageLoadMetricsBrowserTest.IgnoreDownloads test starting with this CL. > > https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/10984 > > Original issue's description: > > Cache SubResourceIntegrity checks at Resource > > > > Move SubResourceIntegrity check caches from ScriptResource -> Resource. > > This also renames ScriptIntegrityDisposition to generic name ResourceIntegrityDisposition > > > > This is to prepare for CSSStyleSheetResource to use the same logic. > > Split from https://codereview.chromium.org/2290983003/. > > > > BUG=642722 > > > > Committed: https://crrev.com/6e09a67eb013cde927f50ac7931018a15bfdb2ba > > Cr-Commit-Position: refs/heads/master@{#423792} > > TBR=jww@chromium.org,csharrison@chromium.org,kouhei@chromium.org > BUG=642722 > > Committed: https://crrev.com/7c28430f36a95d35778beb97b31b1c188f37c76e > Cr-Commit-Position: refs/heads/master@{#423946} TBR=csharrison@chromium.org,jww@chromium.org,kouhei@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642722 Committed: https://crrev.com/7e25c52eaa56c35f3afec7265e5f332c261c75b9 Cr-Commit-Position: refs/heads/master@{#424007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -49 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/IntegrityMetadata.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 4 chunks +19 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 3 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.h View 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 2 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nasko
Created Reland of Cache SubResourceIntegrity checks at Resource (patchset #2 id:20001 of https://codereview…
4 years, 2 months ago (2016-10-07 21:45:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398733005/1
4 years, 2 months ago (2016-10-07 21:46:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 23:20:06 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:23:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e25c52eaa56c35f3afec7265e5f332c261c75b9
Cr-Commit-Position: refs/heads/master@{#424007}

Powered by Google App Engine
This is Rietveld 408576698