Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2398733004: Do not SendPasswordForms when LocalFrame is being detached (Closed)
Patch Set: isInStopAllLoaders -> isDetached Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 4bd3bdce4c842217a659d4a8bbe73cdeedee763e..83081bbf87aa5867ca775c70fd56f5888367b487 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -2025,6 +2025,12 @@ bool WebLocalFrameImpl::isLoading() const {
!frame()->document()->loadEventFinished();
}
+bool WebLocalFrameImpl::isDetached() const {
+ if (!frame() || !frame()->client())
esprehn 2016/10/11 22:45:52 I'd prefer if the ->client() check was in core Fra
+ return true;
+ return frame()->isDetached();
+}
+
bool WebLocalFrameImpl::isNavigationScheduledWithin(
double intervalInSeconds) const {
return frame() &&
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698