Do not SendPasswordForms when LocalFrame is being detached

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2007 matching lines @@
 }
 
 bool WebLocalFrameImpl::isLoading() const {
   if (!frame() || !frame()->document())
     return false;
   return frame()->loader().stateMachine()->isDisplayingInitialEmptyDocument() ||
          frame()->loader().provisionalDocumentLoader() ||
          !frame()->document()->loadEventFinished();
 }
 
+bool WebLocalFrameImpl::isDetached() const {
+  if (!frame() || !frame()->client())

[esprehn, 2016/10/11 22:45:52]

I'd prefer if the ->client() check was in core Frame's isDetached(). The way you
have this written isDetached() inside core means something different than
isDetached() inside web/

+    return true;
+  return frame()->isDetached();
+}
+
 bool WebLocalFrameImpl::isNavigationScheduledWithin(
     double intervalInSeconds) const {
   return frame() &&
          frame()->navigationScheduler().isNavigationScheduledWithin(
              intervalInSeconds);
 }
 
 void WebLocalFrameImpl::setCommittedFirstRealLoad() {
   DCHECK(frame());
   ensureFrameLoaderHasCommitted(frame()->loader());
@@ skipping 302 matching lines @@
     feature = UseCounter::ChromeLoadTimesNpnNegotiatedProtocol;
   } else if (metric == "wasAlternateProtocolAvailable") {
     feature = UseCounter::ChromeLoadTimesWasAlternateProtocolAvailable;
   } else if (metric == "connectionInfo") {
     feature = UseCounter::ChromeLoadTimesConnectionInfo;
   }
   UseCounter::count(frame(), feature);
 }
 
 }  // namespace blink