Make the AbstractParallelRebaselineCommand rebaseline function public/non-protected.

Make the AbstractParallelRebaselineCommand rebaseline function public/non-protected.

Reason: In practice, this method is called from outside the class and treated as public. This is a minor CL that doesn't affect behavior.

BUG=643937
Committed: https://crrev.com/fdcd00fcf383479c62f41ce1e4a5ddace9eb7704
Cr-Commit-Position: refs/heads/master@{#423356}

[qyearsley, 2016-10-05 18:37:25]

Description was changed from

==========
Make the AbstractParallelRebaselineCommand rebaseline function
public/non-protected.
==========

to

==========
Make the AbstractParallelRebaselineCommand rebaseline function
public/non-protected.

Reason: In practice, this method is called from outside the class and treated as
public. This is a minor CL that doesn't affect behavior.

BUG=643937
==========

[qyearsley, 2016-10-05 18:37:25]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org, wkorman@chromium.org

[jeffcarp, 2016-10-05 21:17:44]

One nit, otherwise lgtm

https://codereview.chromium.org/2398733002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
(right):

https://codereview.chromium.org/2398733002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py:166:
port.host.filesystem.join(port.layout_tests_dir(),
'fast/dom/prototype-taco.html'),
This looks like it might not belong in this CL?

[qyearsley, 2016-10-05 23:09:53]

https://codereview.chromium.org/2398733002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
(right):

https://codereview.chromium.org/2398733002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py:166:
port.host.filesystem.join(port.layout_tests_dir(),
'fast/dom/prototype-taco.html'),
On 2016/10/05 at 21:17:44, jeffcarp wrote:
> This looks like it might not belong in this CL?

You're right -- it's not related to the topic of the CL.

I put it here because it's related to the TODO listed above, but this line
should now be changed by http://crrev.com/2399613002 so after rebasing after
that change, this line should not be changed by this CL.

[qyearsley, 2016-10-05 23:26:55]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-10-05 23:26:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2398733002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-05 23:27:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 00:29:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 00:30:36]

Description was changed from

==========
Make the AbstractParallelRebaselineCommand rebaseline function
public/non-protected.

Reason: In practice, this method is called from outside the class and treated as
public. This is a minor CL that doesn't affect behavior.

BUG=643937
==========

to

==========
Make the AbstractParallelRebaselineCommand rebaseline function
public/non-protected.

Reason: In practice, this method is called from outside the class and treated as
public. This is a minor CL that doesn't affect behavior.

BUG=643937

Committed: https://crrev.com/fdcd00fcf383479c62f41ce1e4a5ddace9eb7704
Cr-Commit-Position: refs/heads/master@{#423356}
==========

[commit-bot: I haz the power, 2016-10-06 00:30:38]

Patchset 2 (id:??) landed as
https://crrev.com/fdcd00fcf383479c62f41ce1e4a5ddace9eb7704
Cr-Commit-Position: refs/heads/master@{#423356}