Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2398733002: Make the AbstractParallelRebaselineCommand rebaseline function public/non-protected. (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 78d3011ce956a8cf498a29b47acf6128c0065aee..a4aa366f19f51148c2139a5571c5a88e8fb0bce2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -499,7 +499,7 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
change_set = self._extract_scm_changes(command_results)
# TODO(qyearsley): Instead of updating the SCM state here, aggregate changes
- # and update once in _rebaseline. See http://crbug.com/639410.
+ # and update once in rebaseline. See http://crbug.com/639410.
if update_scm:
if change_set.files_to_delete:
self._tool.scm().delete_list(change_set.files_to_delete)
@@ -508,7 +508,7 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
return change_set.lines_to_remove
- def _rebaseline(self, options, test_prefix_list, update_scm=True):
+ def rebaseline(self, options, test_prefix_list, update_scm=True):
"""Downloads new baselines in parallel, then updates expectations files
and optimizes baselines.
@@ -589,7 +589,7 @@ class RebaselineJson(AbstractParallelRebaselineCommand):
def execute(self, options, args, tool):
self._tool = tool
- self._rebaseline(options, json.loads(sys.stdin.read()))
+ self.rebaseline(options, json.loads(sys.stdin.read()))
class RebaselineExpectations(AbstractParallelRebaselineCommand):
@@ -639,7 +639,7 @@ class RebaselineExpectations(AbstractParallelRebaselineCommand):
_log.warning("Did not find any tests marked Rebaseline.")
return
- self._rebaseline(options, self._test_prefix_list)
+ self.rebaseline(options, self._test_prefix_list)
class Rebaseline(AbstractParallelRebaselineCommand):
@@ -689,4 +689,4 @@ class Rebaseline(AbstractParallelRebaselineCommand):
if options.verbose:
_log.debug("rebaseline-json: " + str(test_prefix_list))
- self._rebaseline(options, test_prefix_list)
+ self.rebaseline(options, test_prefix_list)

Powered by Google App Engine
This is Rietveld 408576698