Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 239863003: Revert of Oilpan: fix build after r171701 (Closed)

Created:
6 years, 8 months ago by hayato
Modified:
6 years, 8 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Yoav Weiss, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Oilpan: fix build after r171701 (https://codereview.chromium.org/239603006/) Reason for revert: [blink gardening] This patch is on the top of https://codereview.chromium.org/224733011, which I am going to revert after this reverting. See the comment of https://codereview.chromium.org/224733011 for the revert. Original issue's description: > Oilpan: fix build after r171701 > > NOTRY=true > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171724 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/core/css/parser/SizesAttributeParser.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/parser/SizesAttributeParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hayato
Created Revert of Oilpan: fix build after r171701
6 years, 8 months ago (2014-04-16 06:39:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/239863003/1
6 years, 8 months ago (2014-04-16 06:40:06 UTC) #2
commit-bot: I haz the power
Change committed as 171750
6 years, 8 months ago (2014-04-16 06:40:28 UTC) #3
haraken
6 years, 8 months ago (2014-04-16 07:47:44 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698