Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2398603002: [turbofan][x64] Improve code generation for external reference access. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan][x64] Improve code generation for external reference access. Properly fold external reference access into memory operands whenever possible, i.e. for accessing the allocation top/limit, similar to what we do in Crankshaft and hand-written native code. This only works when the serializer is disabled, i.e. doesn't apply to the stubs in the snapshot (for now). This reduces register pressure especially around allocations where we'd currently need two registers to hold both the allocation top and limit pointers in registers (on x64). R=epertoso@chromium.org Committed: https://crrev.com/7500e5077caaddf84e26a4c2356fb69f3edc7be5 Cr-Commit-Position: refs/heads/master@{#39993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M src/compiler/instruction-selector.h View 4 chunks +9 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 3 chunks +9 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 4 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-05 12:13:38 UTC) #1
epertoso
lgtm
4 years, 2 months ago (2016-10-05 12:26:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398603002/1
4 years, 2 months ago (2016-10-05 12:33:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 13:07:07 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:07:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7500e5077caaddf84e26a4c2356fb69f3edc7be5
Cr-Commit-Position: refs/heads/master@{#39993}

Powered by Google App Engine
This is Rietveld 408576698