|
Implement search engine auto switch when entering or leaving some locale
Search engine auto switch is a feature that Chrome sets the default
search engine automatically when it detects changes to the user's
locale. This CL:
1. Enables Chrome to check locale info in onResume().
2. Shows a snackbar if such auto switch is made.
To prevent memory leak, LocaleMangaer only keeps a weak ref to the
snackbar manager, which is only owned by the ChromeActivity. Also since
onStartWithNative() might happen before snackbar manager is ready, locale
manager initialization is now moved to onResumeWithNative() to guarantee
that snackbar manager will be ready when we detect locale changes.
BUG= 638062
R=isherman@chromium.org, mariakhomenko@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/9b5bdfbaf2dc936913995b772b2dc419604297ab
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+158 lines, -13 lines) |
Patch |
|
M |
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
|
View
|
|
5 chunks |
+8 lines, -4 lines |
1 comment
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
|
View
|
|
3 chunks |
+96 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/locale/SearchEnginePromoDialog.java
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/locale/SpecialLocaleHandler.java
|
View
|
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
|
View
|
|
3 chunks |
+11 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/strings/android_chrome_strings.grd
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/android/locale/special_locale_handler.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/android/locale/special_locale_handler.cc
|
View
|
|
1 chunk |
+19 lines, -0 lines |
0 comments
|
Download
|
|
M |
tools/metrics/histograms/histograms.xml
|
View
|
|
1 chunk |
+1 line, -0 lines |
1 comment
|
Download
|
Depends on Patchset:
Total messages: 14 (7 generated)
|