Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2385543002: Adjust Chrome to normal behavior once user leaves special locale (Closed)

Created:
4 years, 2 months ago by Ian Wen
Modified:
4 years, 2 months ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust Chrome to normal behavior once user leaves special locale If the user leaves a special locale, changes we made previously shall be reverted. BUG=638062 Committed: https://crrev.com/2673b44190275c1faaea0cc90222e8a3ff95479c Cr-Commit-Position: refs/heads/master@{#422956}

Patch Set 1 #

Patch Set 2 : remove destroy() #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : comments #

Patch Set 6 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 1 2 3 4 5 chunks +15 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2380133002 Patch 60001

Dependent Patchsets:

Issue 2398533002 Patch 1

Messages

Total messages: 15 (7 generated)
Ian Wen
PTAL :)
4 years, 2 months ago (2016-09-30 00:32:10 UTC) #2
Maria
lgtm https://codereview.chromium.org/2385543002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2385543002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode397 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:397: mLocaleManager.stopObservePhoneStateChanges(); nit: how about calling these two methods ...
4 years, 2 months ago (2016-10-04 03:48:41 UTC) #3
Ian Wen
https://chromiumcodereview.appspot.com/2385543002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://chromiumcodereview.appspot.com/2385543002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode397 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:397: mLocaleManager.stopObservePhoneStateChanges(); On 2016/10/04 03:48:41, Maria wrote: > nit: how ...
4 years, 2 months ago (2016-10-04 18:31:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385543002/80001
4 years, 2 months ago (2016-10-04 20:02:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/42379)
4 years, 2 months ago (2016-10-04 20:22:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385543002/100001
4 years, 2 months ago (2016-10-04 20:56:36 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-04 22:12:49 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:16:34 UTC) #15
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/2673b44190275c1faaea0cc90222e8a3ff95479c
Cr-Commit-Position: refs/heads/master@{#422956}

Powered by Google App Engine
This is Rietveld 408576698