Chromium Code Reviews| Index: sync/protocol/sync.proto |
| diff --git a/sync/protocol/sync.proto b/sync/protocol/sync.proto |
| index b89b9b74bfa198b63f75193a7d271ea6b8d181b1..302b768ee0a556a70dc5a6c4895ad12095ec391a 100644 |
| --- a/sync/protocol/sync.proto |
| +++ b/sync/protocol/sync.proto |
| @@ -590,6 +590,12 @@ message AuthenticateMessage { |
| required string auth_token = 1; |
| }; |
| +message ClearUserDataMessage { |
| +}; |
| + |
| +message ClearUserDataResponse { |
| +}; |
| + |
| // The client must preserve, store, and resend the chip bag with |
| // every request. The server depends on the chip bag in order |
| // to precisely choreograph a client-server state machines. |
| @@ -637,8 +643,7 @@ message ClientToServerMessage { |
| optional AuthenticateMessage authenticate = 6; |
| // Request to clear all Chromium data from the server. |
| - // DEPRECATED - this field was never used in production. |
| - // optional ClearUserDataMessage clear_user_data = 9; |
| + optional ClearUserDataMessage clear_user_data = 9; |
|
rlarocque
2013/09/06 21:56:44
I guess I'm not opposed to this change, but why di
pval...(no longer on Chromium)
2013/09/06 22:08:59
as we discussed offline, this was added back for t
|
| optional string store_birthday = 7; // Opaque store ID; if it changes, duck! |
| // The client sets this if it detects a sync issue. The server will tell it |
| @@ -668,6 +673,27 @@ message ClientToServerMessage { |
| optional string invalidator_client_id = 14; |
| }; |
| +// This request allows the client to convert a specific crash identifier |
| +// into more general information (e.g. hash of the crashing call stack) |
| +// suitable for upload in an (authenticated) DebugInfo event. |
| +message GetCrashInfoRequest { |
| + // Id of the uploaded crash |
|
rlarocque
2013/09/06 21:56:44
Add a period?
pval...(no longer on Chromium)
2013/09/06 22:08:59
Done.
|
| + optional string crash_id = 1; |
| + |
| + // Time that the crash occurred |
|
rlarocque
2013/09/06 21:56:44
period?
pval...(no longer on Chromium)
2013/09/06 22:08:59
Done.
|
| + optional int64 crash_time_millis = 2; |
| +} |
| + |
| +// Proto to be written in its entirety to the debug info log |
|
rlarocque
2013/09/06 21:56:44
period?
pval...(no longer on Chromium)
2013/09/06 22:08:59
Done.
|
| +message GetCrashInfoResponse { |
| + // Hash of the crashing calltack. |
|
rlarocque
2013/09/06 21:56:44
typo: calltack.
pval...(no longer on Chromium)
2013/09/06 22:08:59
Done.
|
| + optional string stack_id = 1; |
| + |
| + // Time of the crash, potentially rounded to remove |
| + // significant bits. |
| + optional int64 crash_time_millis = 2; |
| +} |
| + |
| message CommitResponse { |
| enum ResponseType { |
| SUCCESS = 1; |
| @@ -836,8 +862,7 @@ message ClientToServerResponse { |
| optional ClientCommand client_command = 7; |
| optional ProfilingData profiling_data = 8; |
| - // DEPRECATED - this field was never used in production. |
| - // optional ClearUserDataResponse clear_user_data = 9; |
| + optional ClearUserDataResponse clear_user_data = 9; |
| optional GetUpdatesMetadataResponse stream_metadata = 10; |
| // If GetUpdatesStreamingResponse is contained in the ClientToServerResponse, |
| // none of the other fields (error_code and etc) will be set. |