Update client-side sync.proto file so that it is in sync

sync/protocol/sync.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol for communication between sync client and server.
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
@@ skipping 572 matching lines @@
   // This value is an udpated version of the GetUpdatesCallerInfo's
   // GetUpdatesSource.  It describes the reason for the GetUpdate request.
   // Introduced in M29.
   optional SyncEnums.GetUpdatesOrigin get_updates_origin = 9;
 };
 
 message AuthenticateMessage {
   required string auth_token = 1;
 };
 
+message ClearUserDataMessage {
+};
+
+message ClearUserDataResponse {
+};
+
 // The client must preserve, store, and resend the chip bag with
 // every request.  The server depends on the chip bag in order
 // to precisely choreograph a client-server state machines.
 //
 // Because the client stores and sends this data on every request,
 // the contents of the chip bag should be kept relatively small.
 //
 // If the server does not return a chip bag, the client must assume
 // that there has been no change to the chip bag.  The client must
 // resend the bag of chips it had prior on the next request.
@@ skipping 27 matching lines @@
     AUTHENTICATE = 3;
     CLEAR_DATA = 4;
   }
 
   required Contents message_contents = 3;
   optional CommitMessage commit = 4;
   optional GetUpdatesMessage get_updates = 5;
   optional AuthenticateMessage authenticate = 6;
 
   // Request to clear all Chromium data from the server.
-  // DEPRECATED - this field was never used in production.
-  // optional ClearUserDataMessage clear_user_data = 9;
+  optional ClearUserDataMessage clear_user_data = 9;

[rlarocque, 2013/09/06 21:56:44]

I guess I'm not opposed to this change, but why did it happen?

Could we use the deprecated option here?

[pval...(no longer on Chromium), 2013/09/06 22:08:59]

as we discussed offline, this was added back for testing. the client side just
isn't implemented yet.

 
   optional string store_birthday = 7; // Opaque store ID; if it changes, duck!
   // The client sets this if it detects a sync issue. The server will tell it
   // if it should perform a refresh.
   optional bool sync_problem_detected = 8 [default = false];
 
   // Client side state information for debugging purpose.
   // This is only sent on the first getupdates of every sync cycle,
   // as an optimization to save bandwidth.
   optional DebugInfo debug_info = 10;
 
   // Per-client state for use by the server. Sent with every message sent to the
   // server.
   optional ChipBag bag_of_chips = 11;
 
   // Google API key.
   optional string api_key = 12;
 
   // Client's self-reported state.
   // The client should set this on every message sent to the server, though its
   // member fields may often be unset.
   optional ClientStatus client_status = 13;
 
   // The ID that our invalidation client used to identify itself to the server.
   // Sending the ID here allows the server to not send notifications of our own
   // changes to our invalidator.
   optional string invalidator_client_id = 14;
 };
 
+// This request allows the client to convert a specific crash identifier
+// into more general information (e.g. hash of the crashing call stack)
+// suitable for upload in an (authenticated) DebugInfo event.
+message GetCrashInfoRequest {
+  // Id of the uploaded crash

[rlarocque, 2013/09/06 21:56:44]

Add a period?

[pval...(no longer on Chromium), 2013/09/06 22:08:59]

Done.

+  optional string crash_id = 1;
+
+  // Time that the crash occurred

[rlarocque, 2013/09/06 21:56:44]

period?

[pval...(no longer on Chromium), 2013/09/06 22:08:59]

Done.

+  optional int64 crash_time_millis = 2;
+}
+
+// Proto to be written in its entirety to the debug info log

[rlarocque, 2013/09/06 21:56:44]

period?

[pval...(no longer on Chromium), 2013/09/06 22:08:59]

Done.

+message GetCrashInfoResponse {
+  // Hash of the crashing calltack.

[rlarocque, 2013/09/06 21:56:44]

typo: calltack.

[pval...(no longer on Chromium), 2013/09/06 22:08:59]

Done.

+  optional string stack_id = 1;
+
+  // Time of the crash, potentially rounded to remove
+  // significant bits.
+  optional int64 crash_time_millis = 2;
+}
+
 message CommitResponse {
   enum ResponseType {
     SUCCESS = 1;
     CONFLICT = 2; // You're out of date; update and check your data
     // TODO(ncarter): What's the difference between RETRY and TRANSIENT_ERROR?
     RETRY = 3; // Someone has a conflicting, non-expired session open
     INVALID_MESSAGE = 4; // What the client sent was invalid, and trying again
                          // won't help.
     OVER_QUOTA = 5; // This operation would put you, or you are, over quota
     TRANSIENT_ERROR = 6; // Something went wrong; try again in a bit
@@ skipping 148 matching lines @@
   optional string error_message = 5;
 
   // Opaque store ID; if it changes, the contents of the client's cache
   // is meaningless to this server.  This happens most typically when
   // you switch from one storage backend instance (say, a test instance)
   // to another (say, the official instance).
   optional string store_birthday = 6;
 
   optional ClientCommand client_command = 7;
   optional ProfilingData profiling_data = 8;
-  // DEPRECATED - this field was never used in production.
-  // optional ClearUserDataResponse clear_user_data = 9;
+  optional ClearUserDataResponse clear_user_data = 9;
   optional GetUpdatesMetadataResponse stream_metadata = 10;
   // If GetUpdatesStreamingResponse is contained in the ClientToServerResponse,
   // none of the other fields (error_code and etc) will be set.
   optional GetUpdatesStreamingResponse stream_data = 11;
 
   // The data types whose storage has been migrated.  Present when the value of
   // error_code is MIGRATION_DONE.
   repeated int32 migrated_data_type_id = 12;
 
   message Error {
     optional SyncEnums.ErrorType error_type = 1 [default = UNKNOWN];
     optional string error_description       = 2;
     optional string url                     = 3;
     optional SyncEnums.Action action        = 4 [default = UNKNOWN_ACTION];
 
     // Currently only meaningful if |error_type| is throttled. If this field
     // is absent then the whole client (all datatypes) is throttled.
     repeated int32 error_data_type_ids = 5;
   }
   optional Error error = 13;
 
   // The new per-client state for this client. If set, should be persisted and
   // sent with any subsequent ClientToServerMessages.
   optional ChipBag new_bag_of_chips = 14;
 };