Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 23985004: Update client-side sync.proto file so that it is in sync (Closed)

Created:
7 years, 3 months ago by pval...(no longer on Chromium)
Modified:
7 years, 3 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, albertb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update client-side sync.proto file so that it is in sync with the server-side version BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221910

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M sync/protocol/sync.proto View 1 4 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pval...(no longer on Chromium)
These files got out of sync (server-side modified first), so this CL should correct that. ...
7 years, 3 months ago (2013-09-06 00:55:13 UTC) #1
rlarocque
https://codereview.chromium.org/23985004/diff/1/sync/protocol/sync.proto File sync/protocol/sync.proto (right): https://codereview.chromium.org/23985004/diff/1/sync/protocol/sync.proto#newcode646 sync/protocol/sync.proto:646: optional ClearUserDataMessage clear_user_data = 9; I guess I'm not ...
7 years, 3 months ago (2013-09-06 21:56:43 UTC) #2
pval...(no longer on Chromium)
https://codereview.chromium.org/23985004/diff/1/sync/protocol/sync.proto File sync/protocol/sync.proto (right): https://codereview.chromium.org/23985004/diff/1/sync/protocol/sync.proto#newcode646 sync/protocol/sync.proto:646: optional ClearUserDataMessage clear_user_data = 9; On 2013/09/06 21:56:44, rlarocque ...
7 years, 3 months ago (2013-09-06 22:08:58 UTC) #3
rlarocque
lgtm
7 years, 3 months ago (2013-09-06 22:35:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pvalenzuela@chromium.org/23985004/6001
7 years, 3 months ago (2013-09-06 22:37:08 UTC) #5
pval...(no longer on Chromium)
On 2013/09/06 22:37:08, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 3 months ago (2013-09-07 00:18:57 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 07:20:05 UTC) #7
Message was sent while issue was closed.
Change committed as 221910

Powered by Google App Engine
This is Rietveld 408576698