Remove SVN and File support from gclient

Remove SVN and File support from gclient

FileImpl was only usable with SVN.

R=maruel@chromium.org
BUG=641588
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a24c3fd5159972f58063967a9c07ef724ff97b

[agable, 2016-10-05 21:06:51]

I've broken the big gclient/presubmit/scm/checkout patch into smaller pieces.
This is the first small piece.

[M-A Ruel, 2016-10-05 21:13:34]

This will likely be the CL that will cause problem. We should leave it in the
tree for a few days before piling on.

https://codereview.chromium.org/2398493004/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/2398493004/diff/1/gclient.py#newcode1635
gclient.py:1635: def CMDcleanup(parser, args):
Let's remove the command.

https://codereview.chromium.org/2398493004/diff/1/gclient.py#newcode1904
gclient.py:1904: parser.add_option('-t', '--transitive', action='store_true',
You can remove it now I think

https://codereview.chromium.org/2398493004/diff/1/gclient.py#newcode1930
gclient.py:1930: parser.add_option('-m', '--manually_grab_svn_rev',
action='store_true',
same

[agable, 2016-10-05 22:23:38]

Agreed on letting this one bake before landing any of the followups. This one is
all the user-facing stuff, while the next one is just scaffolding.

https://codereview.chromium.org/2398493004/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/2398493004/diff/1/gclient.py#newcode1635
gclient.py:1635: def CMDcleanup(parser, args):
On 2016/10/05 at 21:13:33, M-A Ruel wrote:
> Let's remove the command.

Will do in followup CL. (Removing it from gclient_scm.SVNWrapper is hard, so
I'll remove it from Git after that's been deleted entirely.)
https://codereview.chromium.org/2401483002

https://codereview.chromium.org/2398493004/diff/1/gclient.py#newcode1904
gclient.py:1904: parser.add_option('-t', '--transitive', action='store_true',
On 2016/10/05 at 21:13:33, M-A Ruel wrote:
> You can remove it now I think

Done

https://codereview.chromium.org/2398493004/diff/1/gclient.py#newcode1930
gclient.py:1930: parser.add_option('-m', '--manually_grab_svn_rev',
action='store_true',
On 2016/10/05 at 21:13:33, M-A Ruel wrote:
> same

Done

[agable, 2016-10-10 15:57:28]

Ping, so I can land this and let it bake before moving on to the rest of the CLs
in the chain.

[agable, 2016-10-11 00:39:49]

The CQ bit was checked by agable@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 00:39:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 00:43:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 00:43:02]

Dry run: This issue passed the CQ dry run.

[M-A Ruel, 2016-10-11 16:29:24]

sorry, lgtm.

[agable, 2016-10-11 17:39:13]

I'm trooper, so this is a perfect time to land this. Landing.

[agable, 2016-10-11 17:39:15]

The CQ bit was checked by agable@chromium.org

[agable, 2016-10-11 17:39:15]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2398493004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-11 17:39:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 17:42:42]

Description was changed from

==========
Remove SVN and File support from gclient

FileImpl was only usable with SVN.

R=maruel@chromium.org
BUG=641588
==========

to

==========
Remove SVN and File support from gclient

FileImpl was only usable with SVN.

R=maruel@chromium.org
BUG=641588

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a24c3fd51599...
==========

[commit-bot: I haz the power, 2016-10-11 17:42:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a24c3fd51599...

[lpique, 2016-10-11 20:16:25]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2405173003/ by lpique@chromium.org.

The reason for reverting is: The Chrome buildbots pass "--transitive" still.
Removing the option causes them to fail to build.

Example:

https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-....

[agable, 2016-10-11 20:50:19]

A reland of this CL has been created here:
https://codereview.chromium.org/2404413002

It will not be landed until I've removed the use of --transitive from the
chromeos.chrome waterfall.