Reland "Remove SVN and File support from gclient"

Reland "Remove SVN and File support from gclient"

This is a revert of 398a46ee099e74ee5c8f4550eb6eb48899fbe863
Which was itself a revert of b3a24c3fd5159972f58063967a9c07ef724ff97b

BUG=641588
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d437d76b64e083f2fb2ff3a7b38638d06642e270

[agable, 2016-10-11 20:51:04]

Description was changed from

==========
Reland "Remove SVN and File support from gclient"

This is a revert of
https://chromium.googlesource.com/chromium/tools/depot_tools/+/398a46ee099e74...
Which was itself a revert of
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a24c3fd51599...

BUG=641588
==========

to

==========
Reland "Remove SVN and File support from gclient"

This is a revert of 398a46ee099e74ee5c8f4550eb6eb48899fbe863
Which was itself a revert of b3a24c3fd5159972f58063967a9c07ef724ff97b

BUG=641588
==========

[agable, 2016-10-11 20:51:04]

agable@chromium.org changed reviewers:
+ maruel@chromium.org

[agable, 2016-10-14 22:03:33]

agable@chromium.org changed reviewers:
+ dnj@chromium.org

[agable, 2016-10-14 22:03:34]

This is identical to the CL which landed and was reverted, because the failing
code has been changed to no longer use the --transitive flag. I'd like to land
today so I can watch.

[dnj, 2016-10-14 22:08:34]

This may be problematic, depending on whether or not CrOS pins gclient. I don't
think it does, so older branch CrOS builds will still pick this. You need to
cherry-pick your patch to the release milestones.

[agable, 2016-10-14 22:23:30]

On 2016/10/14 at 22:08:34, dnj wrote:
> This may be problematic, depending on whether or not CrOS pins gclient. I
don't think it does, so older branch CrOS builds will still pick this. You need
to cherry-pick your patch to the release milestones.

Ah, that makes sense (although I didn't see any failures on release branch
builders at the time -- maybe just no one linked me to them?). Can you help me
figure out which branches are still active, and who I need to get approvals from
to do the cherry-picks?

[dnj, 2016-10-15 00:23:00]

On 2016/10/14 22:23:30, agable wrote:
> On 2016/10/14 at 22:08:34, dnj wrote:
> > This may be problematic, depending on whether or not CrOS pins gclient. I
> don't think it does, so older branch CrOS builds will still pick this. You
need
> to cherry-pick your patch to the release milestones.
> 
> Ah, that makes sense (although I didn't see any failures on release branch
> builders at the time -- maybe just no one linked me to them?). Can you help me
> figure out which branches are still active, and who I need to get approvals
from
> to do the cherry-picks?

How long was it active? Release for non-beta milestones only builds on demand,
so it's entirely possible nobody triggered a build while your CL was landed.

Minimally, the branches named in here are built:
https://chrome-internal.googlesource.com/chrome/tools/build/+/master/scripts/...

Others may be built by CrOS TPMs - it's sort of hard to predict. For really
thorough coverage, you'd land on any branch whose 4-digit number is >= the
lowest number in the pins JSON:
https://chromium.googlesource.com/chromiumos/manifest.git/+refs

[dnj, 2016-10-15 00:24:21]

On 2016/10/15 00:23:00, dnj wrote:
> On 2016/10/14 22:23:30, agable wrote:
> > On 2016/10/14 at 22:08:34, dnj wrote:
> > > This may be problematic, depending on whether or not CrOS pins gclient. I
> > don't think it does, so older branch CrOS builds will still pick this. You
> need
> > to cherry-pick your patch to the release milestones.
> > 
> > Ah, that makes sense (although I didn't see any failures on release branch
> > builders at the time -- maybe just no one linked me to them?). Can you help
me
> > figure out which branches are still active, and who I need to get approvals
> from
> > to do the cherry-picks?
> 
> How long was it active? Release for non-beta milestones only builds on demand,
> so it's entirely possible nobody triggered a build while your CL was landed.
> 
> Minimally, the branches named in here are built:
>
https://chrome-internal.googlesource.com/chrome/tools/build/+/master/scripts/...
> 
> Others may be built by CrOS TPMs - it's sort of hard to predict. For really
> thorough coverage, you'd land on any branch whose 4-digit number is >= the
> lowest number in the pins JSON:
> https://chromium.googlesource.com/chromiumos/manifest.git/+refs

Actually another option would be to make the option a no-op and put a TODO in to
delete it in 5 months.

[agable, 2016-10-15 00:34:12]

Yeah that's safest. That would be a lot of branches to cherry-pick to. PTAL.

[dnj, 2016-10-15 01:01:12]

difference between PS1 and PS2 LGTM w/ comment.

Do you want me to review the rest?

https://codereview.chromium.org/2404413002/diff/20001/gclient.py
File gclient.py (right):

https://codereview.chromium.org/2404413002/diff/20001/gclient.py#newcode1915
gclient.py:1915: # TODO(agable): Remove these when it is safe to do so.
Document when it is safe: when the oldest CrOS release milestone is M56.

[agable, 2016-10-17 16:04:20]

No need, maruel covered the rest of it last time, unless you really want to for
some masochistic reason.

https://codereview.chromium.org/2404413002/diff/20001/gclient.py
File gclient.py (right):

https://codereview.chromium.org/2404413002/diff/20001/gclient.py#newcode1915
gclient.py:1915: # TODO(agable): Remove these when it is safe to do so.
On 2016/10/15 at 01:01:12, dnj wrote:
> Document when it is safe: when the oldest CrOS release milestone is M56.

Done.

[agable, 2016-10-17 16:32:10]

The CQ bit was checked by agable@chromium.org

[agable, 2016-10-17 16:32:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2404413002/#ps40001
(title: "Comment")

[commit-bot: I haz the power, 2016-10-17 16:32:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 16:35:14]

Description was changed from

==========
Reland "Remove SVN and File support from gclient"

This is a revert of 398a46ee099e74ee5c8f4550eb6eb48899fbe863
Which was itself a revert of b3a24c3fd5159972f58063967a9c07ef724ff97b

BUG=641588
==========

to

==========
Reland "Remove SVN and File support from gclient"

This is a revert of 398a46ee099e74ee5c8f4550eb6eb48899fbe863
Which was itself a revert of b3a24c3fd5159972f58063967a9c07ef724ff97b

BUG=641588

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d437d76b64e083...
==========

[commit-bot: I haz the power, 2016-10-17 16:35:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d437d76b64e083...