Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: src/compiler/simplified-operator.cc

Issue 2398403003: Fix bad reinterpret_cast of StringFromCodePointOperator (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/simplified-operator.cc
diff --git a/src/compiler/simplified-operator.cc b/src/compiler/simplified-operator.cc
index a7bbae3493ce70fc555291f8a4c8f7a3e0f11282..400db97bdcf9d46aec097526afc6f29dfc05303a 100644
--- a/src/compiler/simplified-operator.cc
+++ b/src/compiler/simplified-operator.cc
@@ -474,10 +474,11 @@ struct SimplifiedOperatorGlobalCache final {
#undef CHECKED
template <UnicodeEncoding kEncoding>
- struct StringFromCodePointOperator final : public Operator {
+ struct StringFromCodePointOperator final : public Operator1<UnicodeEncoding> {
StringFromCodePointOperator()
- : Operator(IrOpcode::kStringFromCodePoint, Operator::kPure,
- "StringFromCodePoint", 1, 0, 0, 1, 0, 0) {}
+ : Operator1<UnicodeEncoding>(IrOpcode::kStringFromCodePoint,
+ Operator::kPure, "StringFromCodePoint", 1,
+ 0, 0, 1, 0, 0, kEncoding) {}
caitp 2016/10/07 22:06:12 LGTM, thanks for the fix
};
StringFromCodePointOperator<UnicodeEncoding::UTF16>
kStringFromCodePointOperatorUTF16;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698