Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: src/compiler/simplified-operator.cc

Issue 2398403003: Fix bad reinterpret_cast of StringFromCodePointOperator (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-operator.h" 5 #include "src/compiler/simplified-operator.h"
6 6
7 #include "src/base/lazy-instance.h" 7 #include "src/base/lazy-instance.h"
8 #include "src/compiler/opcodes.h" 8 #include "src/compiler/opcodes.h"
9 #include "src/compiler/operator.h" 9 #include "src/compiler/operator.h"
10 #include "src/compiler/types.h" 10 #include "src/compiler/types.h"
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 Name##Operator() \ 467 Name##Operator() \
468 : Operator(IrOpcode::k##Name, \ 468 : Operator(IrOpcode::k##Name, \
469 Operator::kFoldable | Operator::kNoThrow, #Name, \ 469 Operator::kFoldable | Operator::kNoThrow, #Name, \
470 value_input_count, 1, 1, value_output_count, 1, 0) {} \ 470 value_input_count, 1, 1, value_output_count, 1, 0) {} \
471 }; \ 471 }; \
472 Name##Operator k##Name; 472 Name##Operator k##Name;
473 CHECKED_OP_LIST(CHECKED) 473 CHECKED_OP_LIST(CHECKED)
474 #undef CHECKED 474 #undef CHECKED
475 475
476 template <UnicodeEncoding kEncoding> 476 template <UnicodeEncoding kEncoding>
477 struct StringFromCodePointOperator final : public Operator { 477 struct StringFromCodePointOperator final : public Operator1<UnicodeEncoding> {
478 StringFromCodePointOperator() 478 StringFromCodePointOperator()
479 : Operator(IrOpcode::kStringFromCodePoint, Operator::kPure, 479 : Operator1<UnicodeEncoding>(IrOpcode::kStringFromCodePoint,
480 "StringFromCodePoint", 1, 0, 0, 1, 0, 0) {} 480 Operator::kPure, "StringFromCodePoint", 1,
481 0, 0, 1, 0, 0, kEncoding) {}
caitp 2016/10/07 22:06:12 LGTM, thanks for the fix
481 }; 482 };
482 StringFromCodePointOperator<UnicodeEncoding::UTF16> 483 StringFromCodePointOperator<UnicodeEncoding::UTF16>
483 kStringFromCodePointOperatorUTF16; 484 kStringFromCodePointOperatorUTF16;
484 StringFromCodePointOperator<UnicodeEncoding::UTF32> 485 StringFromCodePointOperator<UnicodeEncoding::UTF32>
485 kStringFromCodePointOperatorUTF32; 486 kStringFromCodePointOperatorUTF32;
486 487
487 struct ArrayBufferWasNeuteredOperator final : public Operator { 488 struct ArrayBufferWasNeuteredOperator final : public Operator {
488 ArrayBufferWasNeuteredOperator() 489 ArrayBufferWasNeuteredOperator()
489 : Operator(IrOpcode::kArrayBufferWasNeutered, Operator::kEliminatable, 490 : Operator(IrOpcode::kArrayBufferWasNeutered, Operator::kEliminatable,
490 "ArrayBufferWasNeutered", 1, 1, 1, 1, 1, 0) {} 491 "ArrayBufferWasNeutered", 1, 1, 1, 1, 1, 0) {}
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
816 Operator::kNoDeopt | Operator::kNoThrow | properties, \ 817 Operator::kNoDeopt | Operator::kNoThrow | properties, \
817 #Name, value_input_count, 1, control_input_count, \ 818 #Name, value_input_count, 1, control_input_count, \
818 output_count, 1, 0, access); \ 819 output_count, 1, 0, access); \
819 } 820 }
820 ACCESS_OP_LIST(ACCESS) 821 ACCESS_OP_LIST(ACCESS)
821 #undef ACCESS 822 #undef ACCESS
822 823
823 } // namespace compiler 824 } // namespace compiler
824 } // namespace internal 825 } // namespace internal
825 } // namespace v8 826 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698