Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2398403003: Fix bad reinterpret_cast of StringFromCodePointOperator (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bad reinterpret_cast of StringFromCodePointOperator StringFromCodePointOperator needed to derive from Operator1<UnicodeEncoding> rather than plain old Operator. This was thankfully caught by the CFI build. R=bmeurer@chromium.org, caitp@chromium.org BUG=v8:5498 Committed: https://crrev.com/ed45f5903c5afdf95cc414c71e1f9f27d5707243 Cr-Commit-Position: refs/heads/master@{#40131}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/compiler/simplified-operator.cc View 1 chunk +4 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
adamk
4 years, 2 months ago (2016-10-07 21:59:12 UTC) #1
caitp
https://codereview.chromium.org/2398403003/diff/1/src/compiler/simplified-operator.cc File src/compiler/simplified-operator.cc (right): https://codereview.chromium.org/2398403003/diff/1/src/compiler/simplified-operator.cc#newcode481 src/compiler/simplified-operator.cc:481: 0, 0, 1, 0, 0, kEncoding) {} LGTM, thanks ...
4 years, 2 months ago (2016-10-07 22:06:12 UTC) #3
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-08 03:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398403003/1
4 years, 2 months ago (2016-10-10 16:15:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 16:58:46 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 16:59:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed45f5903c5afdf95cc414c71e1f9f27d5707243
Cr-Commit-Position: refs/heads/master@{#40131}

Powered by Google App Engine
This is Rietveld 408576698