Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2398303003: Declare dynamic refresh support for ExternalStorageReadOnly policy (Closed)

Created:
4 years, 2 months ago by yamaguchi
Modified:
4 years, 1 month ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, tnagel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip the freature.dynamic_refresh flag of ExternalStorageReadOnly. The policy is applied dynamically after the patch 2401963002: https://codereview.chromium.org/2401963002 Also clarify the behavior when it's unset or false. BUG=629945, 642247 Committed: https://crrev.com/9057be33cf94f10c780e162c534b3e61526b195d Cr-Commit-Position: refs/heads/master@{#432105}

Patch Set 1 #

Patch Set 2 : Sync to head. #

Patch Set 3 : Sync to head. #

Patch Set 4 : Dynamic refresh is implemented from M56. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M components/policy/resources/policy_templates.json View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
yamaguchi
ptal.
4 years, 1 month ago (2016-10-26 04:52:58 UTC) #7
yamaguchi
ptal.
4 years, 1 month ago (2016-11-14 05:57:55 UTC) #10
yamaguchi
I updated the change to reflect latest update of the feature. ptal.
4 years, 1 month ago (2016-11-14 06:08:46 UTC) #12
bartfab (slow)
LGTM. Thanks for the change. Support for dynamic_refresh is always a step in a more ...
4 years, 1 month ago (2016-11-14 10:44:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398303003/60001
4 years, 1 month ago (2016-11-15 01:15:25 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-15 05:04:15 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 05:14:10 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9057be33cf94f10c780e162c534b3e61526b195d
Cr-Commit-Position: refs/heads/master@{#432105}

Powered by Google App Engine
This is Rietveld 408576698