Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2398173002: Disable svgs on nanobench when running on Valgrind (Closed)

Created:
4 years, 2 months ago by stephana
Modified:
4 years, 2 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable svgs on nanobench when running on Valgrind BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2398173002 Committed: https://skia.googlesource.com/skia/+/7fbacbb1e89aeb1f38966d72042acc0339b1f055

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed feedback #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -40 lines) Patch
M infra/bots/recipes/swarm_perf.py View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-GN_Android_Vulkan.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus5-GPU-Adreno330-arm-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus6-GPU-Adreno420-arm-Release-GN_Android.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-GN_Android.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-GN_Android.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 1 chunk +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN.json View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 2 chunks +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/recipe_with_gerrit_patch.json View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
stephana
PTAL The intention here is to not run svg tests on Valgrind, since it causes ...
4 years, 2 months ago (2016-10-06 18:11:36 UTC) #4
borenet
LGTM with nit https://codereview.chromium.org/2398173002/diff/1/infra/bots/recipes/swarm_perf.py File infra/bots/recipes/swarm_perf.py (right): https://codereview.chromium.org/2398173002/diff/1/infra/bots/recipes/swarm_perf.py#newcode199 infra/bots/recipes/swarm_perf.py:199: args.extend(['--svgs', api.flavor.device_dirs.svg_dir]) Nit: 2-space indent.
4 years, 2 months ago (2016-10-06 18:40:10 UTC) #5
stephana
https://codereview.chromium.org/2398173002/diff/1/infra/bots/recipes/swarm_perf.py File infra/bots/recipes/swarm_perf.py (right): https://codereview.chromium.org/2398173002/diff/1/infra/bots/recipes/swarm_perf.py#newcode199 infra/bots/recipes/swarm_perf.py:199: args.extend(['--svgs', api.flavor.device_dirs.svg_dir]) On 2016/10/06 18:40:10, borenet wrote: > Nit: ...
4 years, 2 months ago (2016-10-06 18:57:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398173002/20001
4 years, 2 months ago (2016-10-06 18:57:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/1770) Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, ...
4 years, 2 months ago (2016-10-06 18:58:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398173002/40001
4 years, 2 months ago (2016-10-07 13:18:30 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 13:36:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7fbacbb1e89aeb1f38966d72042acc0339b1f055

Powered by Google App Engine
This is Rietveld 408576698